Record Selector styling

[seancolsen]

Fixes #2104

Before this PR

Figma design

After this PR

Notable differences vs Figma

• I used a thicker outline to indicate focus of the current input.
• I adjusted the yellow color of the match highlight slightly to give it more contrast.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the master branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[seancolsen]

(Re-assigning review to Rajat because I see that Pavish currently has several other PRs to review.)

[pavish]

@seancolsen The consistency fixes PR contains some styling changes which affect the record selector. Do you think you could base your PR on top of it, and resolve conflicts? This would be much faster than the other way around. Also, I expect the consistency fix PR to be merged tomorrow.

[seancolsen]

base your PR on top of it, and resolve conflicts

Thanks for pointing that out, @pavish. Done.

[rajatvijay]

@seancolsen I saw 2 weird things happening here:

1. Layout shift when searching inside the record selector: https://www.loom.com/share/29ca246255cd4ba298fdf9308bca0529
2. In the below screenshot the Acquisition Date has no matches but the results are still shown because of the id and Acquisition price match. It might make sense but it looked a bit weird to me at first look.

[seancolsen]

@rajatvijay This is ready for re-review now.

• Re: (1) Layout shift -- this is tracked in Keep records in store while fetching #1893

• Re: (2) Matches looking weird:

  • I had opened Highlight matching cells in temporal cell types within the Record Selector #1889 a while back to track this issue specifically for temporal types. This partially addresses your comment because you're experiencing unexpected behavior with the "Acquisition Date" column. Today I just updated the description of that ticket, providing a better screenshot an some notes on implementation.

  • I thought I had also addressed this same problem for other data types (e.g. Number, Money), but seeing your screenshot above raised my eyebrows, surprising me that matches within the "id" and "Acquisition Price" columns were not appropriately highlighted.

    I just pushed 361537a to address this. My fix adds match highlighting to Number, Money, Boolean, and Linked Record cell types. You can see the results below.

    

    

    I hope the yellow makes the behavior clear enough to the user.

  • The lack of highlighting in temporal column types is apparent in my second screenshot above by the fact that the first cell in the "date" column is not highlighted. I'm punting this work until later because the fix requires more work since the values can be formatted in different ways but still be equal. We can continue to discuss the details and prioritization of that work within that ticket.

[rajatvijay]

@seancolsen LGTM 🚀

Approved later.

[kgodey]

@rajatvijay I had to dismiss your review to get this merged, please remember to use the "approve" functionality. Otherwise, auto-merge won't work.