New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping support for IE < 8, even optionally? #18

Closed
adamwathan opened this Issue Jan 14, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@adamwathan
Copy link
Contributor

adamwathan commented Jan 14, 2019

Right now : is escaped as \3A instead of \: to support really old versions of IE, like 6 and 7.

This is a bit of a pain because of a bug in css-loader that strips the leading \ from these sort of escape sequences:

webpack-contrib/css-loader#578

It's been open for about 1.5 years and is apparently a difficult fix, but it only affects me personally (and other tailwindcss users) in the case of the : character.

Since market share for IE < 8 is basically zero, it would be amazing if there was a way to just use \: instead of \3A .

Thanks so much for this great library 👍

@mathiasbynens

This comment has been minimized.

Copy link
Owner

mathiasbynens commented Feb 3, 2019

I’d be fine with releasing a new major cssesc version without escapes for legacy browsers. Care to submit a PR?

@adamwathan

This comment has been minimized.

Copy link
Contributor Author

adamwathan commented Feb 3, 2019

Awesome thanks, PR'd in #19, let me know if I missed anything 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment