New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop special behavior for legacy browsers #19

merged 2 commits into from Feb 4, 2019


None yet
3 participants
Copy link

adamwathan commented Feb 3, 2019

This PR removes the special handling of the : character in CSS identifiers so that they simply escaped as \:, and also removes the special handling of leading _ characters in identifiers so they are not escaped.

Hopefully I've followed the build process properly, I noticed there were changes in src/cssesc.js that hadn't been added to the build in /cssesc.js (namely the version number) so those changes were sort of brought in accidentally just by me running the build.


This comment has been minimized.

Copy link

codecov-io commented Feb 3, 2019

Codecov Report

Merging #19 into master will decrease coverage by 1.69%.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #19     +/-   ##
- Coverage     100%   98.3%   -1.7%     
  Files           1       1             
  Lines          63      59      -4     
  Branches       19      17      -2     
- Hits           63      58      -5     
- Misses          0       1      +1
Impacted Files Coverage Δ
cssesc.js 98.3% <83.33%> (-1.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12a4aec...f45bd99. Read the comment docs.

@mathiasbynens mathiasbynens merged commit fe0fa3a into mathiasbynens:master Feb 4, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress

@adamwathan adamwathan referenced this pull request Feb 4, 2019


Update cssesc to 3.0? #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment