Skip to content

Only add custom terminal profile once. #337

Closed
wants to merge 2 commits into from

2 participants

@alimony
alimony commented Feb 11, 2014

This will check if the terminal profile is already set before adding it. Otherwise, duplicate profiles will be added each time .osx is run.

@alimony alimony Only add custom terminal profile once
This will check if the terminal profile is already set before adding it. Otherwise, duplicate profiles will be added each time `.osx` is run.
7d9460b
@mathiasbynens mathiasbynens commented on the diff Feb 11, 2014
@@ -534,10 +534,14 @@ sudo mdutil -E / > /dev/null
defaults write com.apple.terminal StringEncodings -array 4
# Use a modified version of the Pro theme by default in Terminal.app
-open "${HOME}/init/Mathias.terminal"
-sleep 1 # Wait a bit to make sure the theme is loaded
-defaults write com.apple.terminal "Default Window Settings" -string "Mathias"
-defaults write com.apple.terminal "Startup Window Settings" -string "Mathias"
+TERM_PROFILE="Mathias"
@mathiasbynens
Owner

Looks like you’re mixing TERM_PROFILE_NAME and TERM_PROFILE. Typo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@alimony
alimony commented Feb 11, 2014

This is a fix for #336

@alimony
alimony commented Feb 11, 2014

Yes, that was a typo :)

@mathiasbynens mathiasbynens added a commit that referenced this pull request Jun 7, 2014
@alimony alimony .osx: Only install custom Terminal profile once
Closes #336 and #337.
3ece8ac
@ifdattic ifdattic added a commit to ifdattic/dotfiles-old that referenced this pull request Jun 23, 2014
@alimony alimony .osx: Only install custom Terminal profile once
Closes #336 and #337.

Conflicts:
	.osx
d4af3cb
@thorsten thorsten pushed a commit to thorsten/dotfiles that referenced this pull request Dec 12, 2014
@alimony alimony .osx: Only install custom Terminal profile once
Closes #336 and #337.
0247205
@dmcass dmcass pushed a commit to dmcass/windows-dotfiles that referenced this pull request Mar 10, 2015
@alimony alimony .osx: Only install custom Terminal profile once
Closes #336 and #337.
b0dcc53
@Krettis Krettis pushed a commit to Krettis/dotfiles that referenced this pull request Mar 25, 2015
@alimony alimony .osx: Only install custom Terminal profile once
Closes #336 and #337.
c45b71f
@natchiketa natchiketa added a commit to natchiketa/dotfiles that referenced this pull request Jun 25, 2015
@alimony alimony .osx: Only install custom Terminal profile once
Closes #336 and #337.
99a2c5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.