Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some emoji can't match #44

Open
gdutwyg opened this issue Sep 3, 2018 · 4 comments
Open

some emoji can't match #44

gdutwyg opened this issue Sep 3, 2018 · 4 comments

Comments

@gdutwyg
Copy link

@gdutwyg gdutwyg commented Sep 3, 2018

you can try '\u263a'.match(regex) and '\u263a\ufe0f'.match(regex)

result:

'\u263a\ufe0f' can match, but '\u263a' can‘t

@Chaptykov

This comment has been minimized.

Copy link

@Chaptykov Chaptykov commented Sep 5, 2018

I found some emoji not matched with this regexp:

👁🗣🕶🕷🕸🕊🌪🌥🌦🌧🌩🎖🏵🎗🎟🏎🏍🛩🛥🛳🏖🏝🏜🏔🏘🏚🏗🛤🛣🏞🖥🖨🖱🖲🕹🗜
📽🎞🎙🎚🎛🕯🗑🛢🛠🗡🛡🕳🌡🛎🗝🛋🛏🖼 🛍🏷🗒 🗓🗃🗳🗄🗂🗞🖇🖊🖋🖌🖍👁‍🗨♟♾

image

@Chaptykov

This comment has been minimized.

Copy link

@Chaptykov Chaptykov commented Sep 20, 2018

@mathiasbynens Could you comment it, please?

@mpalmerlee

This comment has been minimized.

Copy link

@mpalmerlee mpalmerlee commented Oct 1, 2018

I believe what you want is the text version of the regex that doesn't require the variation selector (U+FE0F)
e.g.:
const emojiRegex = require('emoji-regex/text.js');

@Chaptykov

This comment has been minimized.

Copy link

@Chaptykov Chaptykov commented Oct 23, 2018

Looks like you are right. I think I should be more attentive. Thank you!

ssalka added a commit to ssalka/semantic-release-gitmoji that referenced this issue Feb 25, 2019
ssalka added a commit to ssalka/semantic-release-gitmoji that referenced this issue Feb 25, 2019
@ssalka ssalka mentioned this issue Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.