fix literal underscore encoding #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +34,7 @@ | |||
| }); | |||
| }; | |||
|
|
|||
| var regexUnsafeSymbols = /[\0-\x1F"-\),\.:-@\[-\^`\{-\uFFFF]/g; | |||
| var regexUnsafeSymbols = /[\0-\x1F"-\),\.:-@\[-_`\{-\uFFFF]/g; | |||
There was a problem hiding this comment.
Finally getting back to this. Yes, that was deliberate!
It isn't actually removing the caret ^ because you had the character range [ through ^ (U+005B to U+005E) and by substituting the _ (U+005F) the range is now U+005B to U+005F, still including U+005E.
Of course the character range
\[-_
could be further simplified to
\[-`
(U+005B to U+0060, inclusive) but was trying to be unintrusive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Literal underscore needs to be encoded as
=5For else the encoded product is ambiguous. #4