Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Cat current #2

Merged
merged 46 commits into from

4 participants

Jairo Diaz Graeme Mathieson Richard Taylor Miguel Diaz
Jairo Diaz

Hi Graeme,

We have updated the gem to Rails 3.2, Rspec 2.x and Ruby 1.9.2. We added also soport for the Token Protocol so that it is possible to save the credit card and do new transactions in in the future.

Regards, Jairo

moomerman and others added some commits
Richard Taylor moomerman making it work with ruby 1.9.2 00f1ff8
Richard Taylor moomerman referencing Digest::MD5 directly b421629
Richard Taylor moomerman using the hexdigest methid 401120d
Richard Taylor moomerman fixed deprecation warnings in rails 3.1 0e2afbd
Richard Taylor moomerman added NO (NORWAY) to list of valid country codes 20a00bb
Miguel Diaz gato-omega phase1 porting to 1.9.2 rails 3.1 09930c0
Miguel Diaz gato-omega 1.9.2-p280 working e15ee40
Miguel Diaz gato-omega reintegrated .rvmrc to version control 6787aef
Miguel Diaz gato-omega phase2 porting to 1.9.2 rails 3.1 e01f6ff
Miguel Diaz gato-omega fixed URI-fixes in previous version, with DEFAULT_PARSER UNRESERVED k…
…ey override, much simpler
50cd02c
Miguel Diaz gato-omega phase3 fixes, upgraded activesupport and related gems, i18n was neces…
…sary to comply with activesupport, see if can be fixed
ee00c5a
Miguel Diaz gato-omega now integrating activemodel for validatios, phase 1 5e484f3
Miguel Diaz gato-omega required activemodel correctly 89cfb96
Miguel Diaz gato-omega refactored uri_fixups to override DEFAULT_PARSER and changed some val…
…idations to work with activemodel, in address, command...
d96e7a9
Jairo Diaz jairodiaz changed validates_true_for for validates with :numerality 55f248f
Miguel Diaz gato-omega added spec/support/vendor_config requirement for separating simulator…
…/test config concern from gem
2189b8d
Miguel Diaz gato-omega changed error validations on(X), for [X] to be compatible with active…
…model, validation messages to be changed
17ccab3
Miguel Diaz gato-omega fixed some more validation specs that were out of sync with remarkabl…
…e, just a few remaining
c696a3a
Jairo Diaz jairodiaz added i18n translation file to make pass validation message errors 43b7624
Jairo Diaz jairodiaz solved invalid transaction registration error 3443e56
Jairo Diaz jairodiaz corrected validates_the_format_of errors including original module 9712fe2
Miguel Diaz gato-omega eliminated extra code and comments 69ee65a
Jairo Diaz jairodiaz include information in Readme file 4ecfe4b
Jairo Diaz jairodiaz reformatted readme file e8e2a4e
Jairo Diaz jairodiaz correcting: github shows wrong format for readme file 06e5ae4
Miguel Diaz gato-omega pushed with built gem for current project ca60845
Miguel Diaz gato-omega added token registration command needs testing with TEST environment,…
… as this is not currently supported by simulator!
e721e18
Miguel Diaz gato-omega partial commit for testing gateway responses 181e347
Miguel Diaz gato-omega corrected showpost for tests 45ac28c
Miguel Diaz gato-omega corrected showpost 2 1565553
Miguel Diaz gato-omega added some debug output for testing and an -other- authentication com…
…mand that does not follow the protocol correctly, so it should be dropped to avoid confusion
00fc4dd
Miguel Diaz gato-omega fixed notification for obtaining the remaining params from the respon…
…se for a next url in token registration
d4b2157
Miguel Diaz gato-omega added ExpiryDate and Token for notification d8b41eb
Miguel Diaz gato-omega built gem for use in current_project 74a5da4
Miguel Diaz gato-omega recompiled c825f3a
Miguel Diaz gato-omega removed duplicated hash entry eb9408e
Miguel Diaz gato-omega changed singnature in the case of token registration 4965067
Miguel Diaz gato-omega recompiled d8d1501
Miguel Diaz gato-omega added readers for token and expiry date in notification bbbdb02
Miguel Diaz gato-omega recompiled 9fae889
Jairo Diaz jairodiaz added notication capturer to add test for token 3aea57f
Jairo Diaz jairodiaz Test of token registration notification okay implemented with sinatra f41b5f8
Jairo Diaz jairodiaz Refactored and added token.yml file to save last returned token and used
it for future tests for payment with token
9af0f52
Miguel Diaz gato-omega added sinatra for the test stub server f96f4ec
Miguel Diaz gato-omega added payment with token functionality 58126fa
Miguel Diaz gato-omega removed awesome print marks for notifications 8f65308
Graeme Mathieson
Owner

I'm really sorry I've ignored this pull request for so long. As it happens, I'm about to do another sage pay integration, so you've just saved me a pile of work! I'll review this over the next day or so, get it merged down and make another release of the gem.

I take it this supersedes the previous pull request, so I'll close it now.

Graeme Mathieson mathie was assigned
Graeme Mathieson
Owner

Well, I can certainly say this branch works, as we've trialled it on another app. There's a couple of tweaks I'd like to make (just to keep with house style) before I merge down to master and make a new release, but I'll get there soon.

Thanks for contributing this, you just saved me a tonne of work on a new project!

Graeme Mathieson mathie merged commit 8f65308 into from
Graeme Mathieson
Owner

Hi,

At last, I've merged down most of this pull request and released a new version of the SagePay gem. However, I skipped out on a couple of things:

  • I didn't really understand the authenticate_other method, and there were no tests associated with it, so I removed it for now.

  • I got bogged down in tweaking the token protocol changes, then decided to skip it 'til the next release.

In both instances, it would be awesome if you could resubmit your changes as separate pull requests and I'll integrate them in due course.

Thanks again for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 10, 2011
  1. Richard Taylor
  2. Richard Taylor
  3. Richard Taylor

    using the hexdigest methid

    moomerman authored
Commits on May 16, 2011
  1. Richard Taylor
Commits on Jul 18, 2011
  1. Richard Taylor
Commits on Jan 12, 2012
  1. Miguel Diaz
  2. Miguel Diaz

    1.9.2-p280 working

    gato-omega authored
  3. Miguel Diaz
  4. Miguel Diaz
  5. Miguel Diaz
Commits on Jan 13, 2012
  1. Miguel Diaz

    phase3 fixes, upgraded activesupport and related gems, i18n was neces…

    gato-omega authored
    …sary to comply with activesupport, see if can be fixed
  2. Miguel Diaz
  3. Miguel Diaz
  4. Miguel Diaz

    refactored uri_fixups to override DEFAULT_PARSER and changed some val…

    gato-omega authored
    …idations to work with activemodel, in address, command...
  5. Jairo Diaz
  6. Miguel Diaz

    added spec/support/vendor_config requirement for separating simulator…

    gato-omega authored
    …/test config concern from gem
Commits on Jan 16, 2012
  1. Miguel Diaz

    changed error validations on(X), for [X] to be compatible with active…

    gato-omega authored
    …model, validation messages to be changed
  2. Miguel Diaz
  3. Jairo Diaz
  4. Jairo Diaz
  5. Jairo Diaz
Commits on Jan 17, 2012
  1. Miguel Diaz
Commits on Jan 18, 2012
  1. Jairo Diaz
  2. Jairo Diaz

    reformatted readme file

    jairodiaz authored
  3. Jairo Diaz
Commits on Jan 20, 2012
  1. Miguel Diaz
Commits on Feb 3, 2012
  1. Miguel Diaz

    added token registration command needs testing with TEST environment,…

    gato-omega authored
    … as this is not currently supported by simulator!
Commits on Feb 6, 2012
  1. Miguel Diaz
Commits on Feb 10, 2012
  1. Miguel Diaz
  2. Miguel Diaz

    corrected showpost 2

    gato-omega authored
Commits on Feb 17, 2012
  1. Miguel Diaz

    added some debug output for testing and an -other- authentication com…

    gato-omega authored
    …mand that does not follow the protocol correctly, so it should be dropped to avoid confusion
Commits on Mar 29, 2012
  1. Miguel Diaz

    fixed notification for obtaining the remaining params from the respon…

    gato-omega authored
    …se for a next url in token registration
Commits on Mar 31, 2012
  1. Miguel Diaz
Commits on Apr 1, 2012
  1. Miguel Diaz
Commits on Apr 2, 2012
  1. Miguel Diaz

    recompiled

    gato-omega authored
  2. Miguel Diaz
  3. Miguel Diaz
  4. Miguel Diaz

    recompiled

    gato-omega authored
  5. Miguel Diaz
  6. Miguel Diaz

    recompiled

    gato-omega authored
Commits on Apr 3, 2012
  1. Jairo Diaz
Commits on Apr 4, 2012
  1. Jairo Diaz
  2. Jairo Diaz

    Refactored and added token.yml file to save last returned token and used

    jairodiaz authored
    it for future tests for payment with token
  3. Miguel Diaz
  4. Miguel Diaz
Commits on May 15, 2012
  1. Miguel Diaz
Something went wrong with that request. Please try again.