-
Notifications
You must be signed in to change notification settings - Fork 99
Release 0.3 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.3 #71
Conversation
|
I was planning to make the pull request myself, but was out of town all day yesterday. When I was putting the final touches on things, I checked to see what version jsdom is at, since we have a fixed version in the |
…the base is about:blank. This allows jsdom 3.x to be used.
… or was it never right?)
This makes it easier to use on operating systems (Windows) where /tmp does not exist (and is probably the right thing to do anyhow).
In addition to being more secure, execFile (with arguments as an array) should work on all platforms because it does not require a hardcoded quote character. (On windows, quoting with the single ' causes this call to fail.)
|
OK, I think this is ready to go. I've tested in Windows and MacOS. Shall we merge and tag a release? |
|
Alternatively, we could wait for the CLA for the last couple of pull requests, which look good. |
|
I'm ok with waiting for the CLA a bit (since I made everyone wait a bit while being away). |
Adds an 'extensions' option to config which takes a comma-separated list of extensions to add to the default set. Then adds --extensions parameter to each command-line tool to specify this value. This allows use of MathJax features such as displaying invalid TeX instead of failing to render (--extensions TeX/noUndefined), and stripping out dangerous links from MathML (--extensions Safe).
|
@pkra Is there still a problem with this pull request? |
|
I've been using the develop branch (ie, the soon-to-be 0.3) in production for a couple of weeks now - so could this get a proper npm install too when merged? |
|
@Rycochet you can specify the branch in the npm dependency (cf https://github.com/physikerwelt/mathoid-server/blob/master/package.json#L54) |
|
@physikerwelt CLA is in the process and it's worth our time to wait for it. |
|
@physikerwelt I was meaning on npmjs btw - https://www.npmjs.com/ - would mean it's as simple as "npm install mathjax-node" to get this installed, rather than requiring a full url ;-) |
|
@pkra, if we haven't gotten the CLA for the last few pull requests, I think we should move ahead with this one, as I'd like to see v2.5 be available. |
|
PS, it would also help to update the MathJax-node-2.5 branch of MathJax to include the 2.5.1 changes. |
|
@dpvc the CLA is almost ready (it was much more complex this time). We should be ready today or tomorrow. I'll update the mathjax-node branch. |
|
Actually, update or create new 2.5.1 branch? |
|
I guess you can make |
|
CLA is all set. |
|
By which I mean the CLA for @sammarshallou. |
|
Ok, new mathjax-node branch is ready. Since it's hard to compare the branches: $ git diff --name-status mathjax-node-2.5..mathjax-node-2.5.1
M package.json
M unpacked/MathJax.js
D unpacked/extensions/CHTML-preview.js
D unpacked/extensions/FontWarnings.js
D unpacked/extensions/HTML-CSS/handle-floats.js
D unpacked/extensions/HelpDialog.js
D unpacked/extensions/MatchWebFonts.js
D unpacked/extensions/MathEvents.js
M unpacked/extensions/MathML/mml3.js
D unpacked/extensions/MathMenu.js
D unpacked/extensions/MathZoom.js
D unpacked/extensions/Safe.js
M unpacked/extensions/TeX/AMSmath.js
M unpacked/extensions/TeX/mathchoice.js
M unpacked/extensions/TeX/noErrors.js
M unpacked/extensions/TeX/unicode.js
M unpacked/jax/element/mml/jax.js
M unpacked/jax/output/NativeMML/config.js
M unpacked/jax/output/NativeMML/jax.js |
|
I've updated package.json in the develop branch to use the new MathJax branch. |
|
OK, great. I'll merge the pulls from @sammarshallou and then check that everything is in order, and then we can merge this pull. |
Use OS temp directory os.tmpdir() rather than hard-coded /tmp
Changed Batik calls to use execFile instead of exec
Allow extensions to be specified on command line
|
@Rycochet You are right... a npm package would be nice. I can not build the mathoid debian package from source without a proper npm package. ppa complains that it is not allowed to fetch npm packages from github |
Compensate for removed MathEvents.js.
|
The MathJax branch has been updated and I've merged in the MathEvents fix. |
|
Updated readme and batik readme. |
Are we good to go? E.g., #64 seems fixed now.
Also fixes #85, #82, #70, #62, #31