Use OS temp directory os.tmpdir() rather than hard-coded /tmp #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to use on operating systems (Windows) where /tmp does not exist (and is probably the right thing to do anyhow).
Member
|
This looks good. Although I've done a lot of javascript programming, I am relatively new to node, and don't know all the libraries, so I appreciate the correction. I suspect that Peter will ask that you sign a CLA before we merge your changes. @pkra, is that correct? |
Contributor
|
@sammarshallou could you go fill out http://www.mathjax.org/cla.html ? Thanks! |
Contributor
Author
|
Sure, I've signed the form. |
Contributor
|
@sammarshallou Thanks! Are you contributing privately or as an employee? |
Contributor
Author
|
As an employee. Hope that's okay! I did fill in the relevant box. |
Contributor
|
Not as such but we've actually never had that case before. I'll check what we need and follow up by email. |
dpvc
added a commit
that referenced
this pull request
Mar 20, 2015
Use OS temp directory os.tmpdir() rather than hard-coded /tmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to use on operating systems (Windows) where /tmp
normally does not exist (and is probably the right thing to do anyhow).