Skip to content

Conversation

@zorkow
Copy link
Member

@zorkow zorkow commented Sep 28, 2023

This is a fix for the issue that rendering of script elements with an base element that is wrapped in a TexAtom fails.
E.g., ${\bf a}^b$ fails, while $a^b$ works. But the latter only by accident.

The problem is in the getBaseCore method, where we loop into the base element. However, the loop works effectively on the node and not the wrapper, thus we have to reset both core and node, otherwise we end up with the innermost text node and an error in the baseCharZero method.

@zorkow zorkow requested a review from dpvc September 28, 2023 00:56
@dpvc
Copy link
Member

dpvc commented Sep 28, 2023

OOPS! Good catch. Thanks!

@dpvc dpvc merged commit 1bc54fb into develop Sep 28, 2023
@dpvc dpvc deleted the fix/scriptbase_issue branch September 28, 2023 15:49
@dpvc dpvc added this to the v4.0 milestone Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants