Don't escape contents of PCDATA elements. #127 #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
reviewed
Aug 9, 2018
| * @return{string} The serialized element (like innerHTML) | ||
| */ | ||
| public serializeInner(adaptor: LiteAdaptor, node: LiteElement) { | ||
| const PCDATA = (this.constructor as typeof LiteParser).PCDATA; |
Member
There was a problem hiding this comment.
I don't understand that. PCDATA is static on LiteParser, so can't you just get to that via LiteParser.PCDATA?
Member
Author
There was a problem hiding this comment.
The liteAdaptor is pretty minimal, so it may well need to be subclassed. This allows the subclass's PCDATA to be used. Without this, you would have to override serializeInner() in the subclass just to change the explicit LiteParser reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't escape contents of PCDATA elements, like
<style>and<script>.Resolves issue #127.