Add support for mub/msup/msubsup #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpvc
force-pushed
the
mfrac-improvements
branch
from
d491743 to
7ffb8b1
Compare
zorkow
reviewed
Oct 21, 2017
| /* | ||
| * @return{CHTMLWrapper} The base element's wrapper | ||
| */ | ||
| public get base() { |
Member
There was a problem hiding this comment.
Can we make a name distinction as in mmlnodes base is a position.
| public computeBBox(bbox: BBox) { | ||
| const basebox = this.base.getBBox(); | ||
| const subbox = this.sub.getBBox(); | ||
| const supbox = this.sup.getBBox(); |
Member
Author
There was a problem hiding this comment.
OK, changed to baseChild, supChild, subChild.
Member
Author
|
Changes made. |
Member
|
Lgtn |
zorkow
approved these changes
Nov 17, 2017
Add support for munder/mover/munderover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
msubsup,msub, andmsupelements. It currently doesn't handle italic correction (so positions relative to something like an integral sign will be bad).There is a base class
CHTMLscriptbasethat is the basis for all three elements. It will also be the basis for themunderover,munderandmoverelements, since themovablelimitsattribute can cause the under-over elements to render as sub-sup elements in non-display modes. So the latter under-over elements will be subclasses of the sub-sup classes, and the common under-over methods will be added to theCHTMLscriptbaseclass when under-over support is added.