Skip to content

Conversation

@dpvc
Copy link
Member

@dpvc dpvc commented Oct 15, 2017

Make sqrt line overlap with tall surd top corner glyph for better attachment. Only affects very tall roots that requires multi-character surd. The top corner has always been difficult to align properly with the overline, and this can improve the look (originally suggested in MathJax issue 1838).

Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one comment.

this.addRoot(ROOT, root, sbox);
surd.toCHTML(SURD);
base.toCHTML(BASE);
if (surd.size < 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put a comment here that contains the gist of the explanation for the PR, for future reference?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dpvc dpvc merged commit 45b3770 into italic-correction Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants