-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy extension update #777
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zorkow
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor issues. O/w lgtm.
Co-authored-by: Volker Sorge <v.sorge@mathjax.org>
Co-authored-by: Volker Sorge <v.sorge@mathjax.org>
zorkow
approved these changes
Apr 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the lazy-typesetting extension to add several new features.
There are also a typo in a comment that is fixed, and a redundant definition of
rerender()
in the MathDocument interface declaration was removed.The three bullet points are each done in a separate commit, so it might be easier to look at them separately, rather than mixed together, as in this PR. The third is the most complicated, as there was considerably infrastructure needed to manage that. The new
lazyAlwaysTypeset
option is either an array of container nodes whose contents should always be typeset (non-lazily), or a single string or array of strings that represent CSS selectors for the containers to use. E.g.,lazyAlwaysTypeset: '.always-typeset'
would make all containers with
class="always-typeset"
to have their math typeset regardless of whether they appear in the viewport or not.