-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sre v4 Integration #800
Sre v4 Integration #800
Conversation
Update component files for changes to sre component
…at they can be added before other imports, and so that the combined components work with SRE4. Also, fix sre webpack libs.
Allow SRE to use resolverPath during startup
…into sre4_cleaner_export
…rc into sre4_new_top_component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but I think there is an issue with the promise handling in KeyExplorer. See the discussion in the comments to the code.
Incorporates review suggestions. PTAL. Note, that this also takes care of the path issue that I had mentioned yesterday. So no need for another PR on this. However, I noticed that when a non-existent locale is provided in the option settings, we get a discrepancy in the context menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small changes requested, but otherwise looks good.
Integration of new SRE v4. Depends on SRE v4.0.4.
Changes to SRE integration
SRE can now be imported directly via the file given in its distribution. To keep import clean
sre.ts
now imports all API methods and exports them for use elsewhere. Consequently modules depending on SRE only have to importsre.js
. Files with old type handling (d.ts
files) are removed.Changes to the explorer
Most changes are wrt. the new handling of API methods and updating to new locales. The most significant change in logic is that
setupEngine
now returns a promise itself, indicating when locale loading has been complete. Consequently previously awkward constructions withsreReady
are rewritten inexplorer.ts
but also insemantic-enrich.ts
.Changes to the components
The component integrating SRE is now build similar to other components:
sre
component directory takes care the webpacking. Main filesre.js
and configuration insre_config.js
sre-node
andsre-browser
.semantic-enrich
anda11y
init.js
component subsuming thestartup.js
calls implemented by @dpvcNew component
The PR also includes a new exemplary component
tex-chtml-full-speech
that demonstrates how SRE locales can be included viajson
imports in a MathJax distribution. This ensures that MathJax's internalMathMaps
map is usually empty, keeping builds small and also allowing our lab still to work as usual.