Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG output: replace black with currentColor #1002

Closed
pkra opened this issue Jan 9, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@pkra
Copy link
Member

commented Jan 9, 2015

Could the SVG output set stroke and fill to currentColor? That would allow the SVG output to inherit text color.

I was experimenting with the SVG output and came up with http://codepen.io/pkra/pen/emgeyJ. Here are some cross-platform screenshots.

It seems to be a one-liner at https://github.com/mathjax/MathJax/blob/master/unpacked/jax/output/SVG/jax.js#L2000 ?

What do you think, @dpvc?

@dpvc

This comment has been minimized.

Copy link
Member

commented Jan 11, 2015

Makes sense. I wasn't aware of this setting when the SVG output was written (it was my first use of SVG). I have made the change in the issue1002 branch of my fork of MathJax.

@dpvc dpvc added this to the MathJax 2.5 milestone Jan 11, 2015

dpvc pushed a commit to dpvc/MathJax that referenced this issue Jan 12, 2015

@dpvc

This comment has been minimized.

Copy link
Member

commented Jan 12, 2015

=> Merged

@dpvc dpvc added Merged and removed Ready for Review labels Jan 12, 2015

@dpvc dpvc closed this Jan 12, 2015

@pkra

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2015

Yay. Awesome. Will come up with a test.

@pkra pkra self-assigned this Jan 12, 2015

pkra added a commit to mathjax/MathJax-test that referenced this issue Jan 20, 2015

dpvc pushed a commit to mathjax/MathJax-test that referenced this issue Jan 20, 2015

Davide P. Cervone
Merge pull request #8 from mathjax/issue1002
mathjax/MathJax#1002 -- test SVG output inheriting currentColor

@dpvc dpvc added Test Available and removed Test Needed labels Jan 20, 2015

@dpvc

This comment has been minimized.

Copy link
Member

commented Jan 20, 2015

==> In Testsuite

MathMLToDisplay/General/Colors/issue1002.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.