Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AsciiMath decimal option not working #384

Closed
fred-wang opened this issue Jan 31, 2013 · 6 comments

Comments

Projects
None yet
2 participants
@fred-wang
Copy link
Contributor

commented Jan 31, 2013

The AsciiMath decimal option is not taken into account. This is because the Init() function set the "decimal" variable rather than "decimalsign".

@ghost ghost assigned fred-wang Jan 31, 2013

@fred-wang

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2013

https://github.com/fred-wang/MathJax/compare/master...issue384

AsciiMathToMathML/issue384.html

=> In testsuite, ready for review

@dpvc

This comment has been minimized.

Copy link
Member

commented Jan 31, 2013

Good catch. I'm wondering if we should change the configuration option to be decimalsign as well to correspond with the original AsciiMathML variable. There shouldn't be any backward compatibility issues since it is not working as it is (and never was). In fact, using something like

decimalsign  = (ASCIIMATH.config.decimal || ASCIIMATH.config.decimalsign);

would provide for both (though we would deprecate decimal in favor of decimalsign.

@fred-wang

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2013

I've updated my branch to add this change.

@dpvc

This comment has been minimized.

Copy link
Member

commented Jan 31, 2013

Looks good. I've marked "Ready for Release". That means it can be merged into the develop branch. Do you want to do that, or should I?

@fred-wang

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2013

I think it's fine if you take care of merging the branches into develop.

@dpvc

This comment has been minimized.

Copy link
Member

commented Jan 31, 2013

OK, I've made the merge.

@dpvc dpvc closed this May 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.