# AsciiMath decimal option not working #384

Closed
opened this issue Jan 31, 2013 · 6 comments

Projects
None yet
2 participants
Contributor

### fred-wang commented Jan 31, 2013

 The AsciiMath decimal option is not taken into account. This is because the Init() function set the "decimal" variable rather than "decimalsign".

### ghost assigned fred-wangJan 31, 2013

Contributor Author

### fred-wang commented Jan 31, 2013

 https://github.com/fred-wang/MathJax/compare/master...issue384 AsciiMathToMathML/issue384.html => In testsuite, ready for review
Member

### dpvc commented Jan 31, 2013

 Good catch. I'm wondering if we should change the configuration option to be decimalsign as well to correspond with the original AsciiMathML variable. There shouldn't be any backward compatibility issues since it is not working as it is (and never was). In fact, using something like decimalsign = (ASCIIMATH.config.decimal || ASCIIMATH.config.decimalsign);  would provide for both (though we would deprecate decimal in favor of decimalsign.
Contributor Author

### fred-wang commented Jan 31, 2013

 I've updated my branch to add this change.
Member

### dpvc commented Jan 31, 2013

 Looks good. I've marked "Ready for Release". That means it can be merged into the develop branch. Do you want to do that, or should I?
Contributor Author

### fred-wang commented Jan 31, 2013

 I think it's fine if you take care of merging the branches into develop.
Member