Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

menclose notation in subscripts #414

Closed
pkra opened this issue Mar 18, 2013 · 9 comments

Comments

Projects
None yet
3 participants
@pkra
Copy link
Member

commented Mar 18, 2013

Some menclose options do not work in subscripts. For example, actuarial, madruwb.


<math xmlns="http://www.w3.org/1998/Math/MathML">
  <msub>
    <mi>a</mi>
    <mrow>
      <menclose notation="actuarial">
        <mi>n</mi>
      </menclose>
      <mo>&#x2063;</mo>
      <mi>i</mi>
    </mrow>
  </msub>
</math>
@pkra

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2013

Oh, it's a zoom problem -- the "line disappearing" phenomenon.

@pkra

This comment has been minimized.

Copy link
Member Author

commented Mar 18, 2013

Using Chrome 25 and pasting into the live test, the strikes do not show in default zoom.

@dpvc

This comment has been minimized.

Copy link
Member

commented Mar 19, 2013

OK, it looks like the thickness of the lines are being scaled when they are scripts. That should probably not be the case, (or they should be clamped from below to prevent getting smaller than 1px). I will take out the scaling for now.

dpvc pushed a commit to dpvc/MathJax that referenced this issue Mar 19, 2013

@dpvc

This comment has been minimized.

Copy link
Member

commented Mar 19, 2013

The issue414 branch of my fork of MathJax should resolve this issue.

@fred-wang

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2013

I don't really like this method to comment out old code rather than just removing it, that just makes the code messy. For external developers reading the source, that looks like if the code is still experimental, with core developers still trying various options and searching what's the best one. We certainly need to keep track of the code changes but this is supposed to be done in the Git history...

I would prefer a comment indicating what this "t" variable is used for. Then if you feel it important, you may also explain in this comment why the scale is not included in the computation and add a reference to issue 414.

BTW, this commit might be in conflict with the one from issue 362.

@fred-wang

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2013

=> Do not write automated tests

dpvc pushed a commit to dpvc/MathJax that referenced this issue Mar 20, 2013

@dpvc

This comment has been minimized.

Copy link
Member

commented Mar 20, 2013

OK, I added comments and removed the commented code.

I don't think this conflicts with issue 362 as the changes you made to menclose.js there are not the same lines as I change here, and I think that means they will merge properly.

@fred-wang

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2013

OK, thanks.

=> Ready for release.

@dpvc

This comment has been minimized.

Copy link
Member

commented Mar 20, 2013

OK, merged into develop.

@dpvc dpvc closed this May 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.