Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Chrome measurements back to em's from px's #443

Closed
dpvc opened this issue Apr 19, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@dpvc
Copy link
Member

commented Apr 19, 2013

The change was made originally in order to work around some positioning problems in Chrome, but this change causes other problems (like bad results if MathJax is used inside an animation on the font-size, or if the font size is different in screen and print media).

Try to change this back to em's (use rounding to pixel sizes in order to try to avoid the spacing problems).

@ghost ghost assigned dpvc Apr 19, 2013

@dpvc

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2013

This is related to issue #386 and #295

dpvc pushed a commit to dpvc/MathJax that referenced this issue Apr 22, 2013

Davide P. Cervone
Use ems (rounded to nearest pixel) for Chrome. Rounding makes the pla…
…cement work more reliably, while still being in relative units. Resolves issue mathjax#443.
@dpvc

This comment has been minimized.

Copy link
Member Author

commented Apr 22, 2013

The issue443 branch of my fork of MathJax includes the fix.

=> Ready for review

@fred-wang

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2013

Let's merge it and see how it impacts the test results.

=> Ready for release.

dpvc pushed a commit to dpvc/MathJax that referenced this issue Apr 29, 2013

@dpvc

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2013

=> Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.