Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean attributes to \mmlToken are being saved as strings #451

Closed
dpvc opened this issue Apr 26, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@dpvc
Copy link
Member

commented Apr 26, 2013

Attributes that are true or false should be converted from strings to boolean when the internal MathML is created (as they are by the MathML input jax). Without that, something like

\mmlToken{mo}[accent="false"]{←}

will have accent equal to the string false, which will end up registering as true in the javascript.

@ghost ghost assigned dpvc Apr 26, 2013

dpvc pushed a commit to dpvc/MathJax that referenced this issue Apr 26, 2013

@dpvc

This comment has been minimized.

Copy link
Member Author

commented Apr 26, 2013

The issue451 branch of my fork of MathJax fixes the problem.

=> Ready for Review

@fred-wang

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2013

=> Ready for release, In testsuite

The test will be

LaTeXToMathML/non-standard/mmlToken-1.html

dpvc pushed a commit to dpvc/MathJax that referenced this issue Apr 29, 2013

@dpvc

This comment has been minimized.

Copy link
Member Author

commented Apr 29, 2013

=> Merged

@dpvc dpvc closed this May 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.