Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double-Click zoom trigger no longer works #590

Closed
dpvc opened this issue Sep 29, 2013 · 2 comments

Comments

Projects
None yet
2 participants
@dpvc
Copy link
Member

commented Sep 29, 2013

Setting the zoom trigger to Double-Click no longer works. This is due to the localization changes, which now stores the localization key rather than the translation as the menu setting value. So the check for trigger name in MathMenu.js should be for DoubleClick rather than Double-Click.

That is easily fixed, but if a page author has set the menuSettings.zoom to the old value of "Double-Click" this will no longer work. So we should either have MathMenu.js look for both, or have MathJax convert Double-Click to DoubleClick during configuration.

@dpvc

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2013

I think the fix for this should be included in v2.3

@ghost ghost assigned fred-wang Oct 14, 2013

@dpvc

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2013

Looks good.

=> Ready for Release

fred-wang added a commit that referenced this issue Oct 15, 2013

Merge pull request #608 from fred-wang/issue590
Make MathZoom check the new DoubleClick value. #590

@fred-wang fred-wang closed this Oct 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.