Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 11 recognized as Firefox #658

Closed
pkra opened this issue Nov 6, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@pkra
Copy link
Member

commented Nov 6, 2013

I can confirm this User Group posting https://groups.google.com/forum/#!topic/mathjax-users/YtIdzwWCAXs on Windows 8.1 preview.

MathJax.Hub.Browser gives me Firefox. Version is "correctly" given as 11.

@pkra

This comment has been minimized.

Copy link
Member Author

commented Nov 17, 2013

Thanks for finding those, Fred.

@dpvc

This comment has been minimized.

Copy link
Member

commented Dec 10, 2013

The issue here is that MathJax does the tests for isFirefox, isMSIE, etc, in parallel, and then sets the MathJax.Hub.Browser by looping through is* values in no particular order. In this case, it actually sets both the isMSIE and the isFirefox values to true, and apparently the loop does isFirefox last, and so leaves the browser set as Firefox.

This can certainly be fixed, but I want to think about the implications of the different possibilities.

Ironically, had we left my original test for Firefox (that looked for characteristics of the browser rather than pattern matching the user agent string), then this would not have occurred.

Reworking some of this might offer an opportunity to change from browser- to engine-based names instead, as Fred has suggested. So isWebKit and isGecko, for example. This would require changes in lots of places (including changes to version numbers, since these would now be the engine version rather than the browser version).

@ghost ghost assigned dpvc Jan 9, 2014

dpvc pushed a commit to dpvc/MathJax that referenced this issue Jan 13, 2014

@dpvc dpvc added Ready for Review and removed In Development labels Feb 5, 2014

@dpvc

This comment has been minimized.

Copy link
Member

commented Feb 12, 2014

=> Merged.

@dpvc dpvc added Merged and removed Ready for Review labels Feb 12, 2014

@dpvc dpvc removed their assignment Feb 12, 2014

@dpvc dpvc closed this Feb 12, 2014

dpvc pushed a commit to mathjax/MathJax-test that referenced this issue Apr 22, 2014

@dpvc

This comment has been minimized.

Copy link
Member

commented Apr 22, 2014

=> In Test Suite

Parsing/issue658.html (used to test for ALL browsers).

@dpvc dpvc added v2.4 and removed Merged labels Jun 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.