Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative indentshift values aren't handled properly #769

Closed
dpvc opened this issue Mar 14, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@dpvc
Copy link
Member

commented Mar 14, 2014

It looks like negative indentshift is supposed to indent from the opposite side? See this example from the MathML3 test suite.

@dpvc dpvc added this to the Next Release milestone Aug 19, 2014

@pkra

This comment has been minimized.

@dpvc

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2014

The key idea is that indentshift is an offset from the default indent, not the actual amount of indenting (which is what I thought it was). So a negative indent shifts to the left. When indentalign is right, you need to use a negative indent to move in from the right-hand margin.

The discussion also clarifies percentages and the initial indenting for the first line. (MathJax currently is doing it correctly.)

dpvc pushed a commit to dpvc/MathJax that referenced this issue Sep 9, 2014

Davide P. Cervone
Fix multiple problems with indentshift and indentalign in HTML-CSS an…
…d SVG output. (Negative values not handled properly, shift not applied to centering, SVG not handling shift past edges well, percentage shifts now in relation to container, etc.) Resolves issues mathjax#769 and mathjax#768.
@dpvc

This comment has been minimized.

Copy link
Member Author

commented Sep 9, 2014

This and a number of other indent issues is handled in the issue769 branch of my fork of MathJax. There really needs to be a number of test cases for this (left/center/right, with indents negative/zero/positive, going past edges of container, with labels, with and without line breaks, with displayAlign and displayIdent, and with indentalign and indentshift attributes).

@dpvc

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2014

==> Merged.

@dpvc dpvc added Merged and removed Ready for Review labels Sep 11, 2014

@dpvc dpvc closed this Sep 11, 2014

dpvc pushed a commit to mathjax/MathJax-test that referenced this issue Jan 17, 2015

dpvc pushed a commit to mathjax/MathJax-test that referenced this issue Jan 22, 2015

@dpvc dpvc added Test Available and removed Test Needed labels Jan 22, 2015

@dpvc

This comment has been minimized.

Copy link
Member Author

commented Jan 22, 2015

==> In Testsuite

MathMLToDisplay/Topics/LineBreak/issue769-1a.html
MathMLToDisplay/Topics/LineBreak/issue769-1b.html
MathMLToDisplay/Topics/LineBreak/issue769-2a.html
MathMLToDisplay/Topics/LineBreak/issue769-2b.html
MathMLToDisplay/Topics/LineBreak/issue769-3a.html
MathMLToDisplay/Topics/LineBreak/issue769-3b.html
MathMLToDisplay/Topics/LineBreak/issue769-4a.html
MathMLToDisplay/Topics/LineBreak/issue769-4b.html
MathMLToDisplay/Topics/LineBreak/issue769-5a.html
MathMLToDisplay/Topics/LineBreak/issue769-5b.html
MathMLToDisplay/Topics/LineBreak/issue769-6a.html
MathMLToDisplay/Topics/LineBreak/issue769-6b.html

@dpvc dpvc added Fixed v2.5 and removed Merged labels Jan 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.