Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus in RTL have arrows that point the wrong way #777

Closed
amire80 opened this issue Mar 29, 2014 · 8 comments

Comments

Projects
None yet
2 participants
@amire80
Copy link

commented Mar 29, 2014

When MathJax is set to Hebrew user interface and I right-click a formula, I see the pop-up menu items correctly aligned to the right (thank you very much for this, MathJax developers!). There's one glitch in the RTL support here: The sub-menus in items such as "Show Math As" open on the right-hand side of the main menu, and the arrows point to the right as well. In a right-to-left language, the arrows are supposed to point to the left and the sub-menus are supposed to open there as well.

(I tested the implementation of MathJax in Wikipedia.)

@dpvc dpvc added the Accepted label Mar 30, 2014

@dpvc

This comment has been minimized.

Copy link
Member

commented Mar 30, 2014

Thanks for the information. The RTL support is pretty rudimentary at the moment, and there is a lot of work that still needs to be done for this, so it is good to hear from you what needs adjusting. It is not something I know a lot about, but will learn more when we do a more thorough implementation of RTL.

@dpvc dpvc added this to the Bugfix Version milestone Apr 9, 2014

dpvc pushed a commit to dpvc/MathJax that referenced this issue Apr 9, 2014

@dpvc

This comment has been minimized.

Copy link
Member

commented Apr 9, 2014

OK, I've made the changes that are needed to make the menus point and open in the proper direction. I hope that does the trick for you.

dpvc pushed a commit to dpvc/MathJax that referenced this issue Apr 11, 2014

@dpvc dpvc added Merged and removed Ready for Review labels Apr 11, 2014

@dpvc

This comment has been minimized.

Copy link
Member

commented Apr 11, 2014

=> Merged.

@amire80

This comment has been minimized.

Copy link
Author

commented Apr 19, 2014

Thanks! How can I test this fix? I cloned and checked out the develop branch. I see the RTL fix in unpacked/extensions/MathMenu.js, but not in the minified file under the extensions/ directory. I looked for some kind of a build script that packs it, but couldn't find it. What should I do?

@dpvc

This comment has been minimized.

Copy link
Member

commented Apr 19, 2014

You are right, we don't pack the changed version until the final distribution. If you want to try it on some of your test pages, simply use mathjax/unpacked/MathJax.js?config=... rather than mathjax/MathJax.js?config=/... to use the uncompressed version. There is no need to compress it in order to do testing. Let me know if that's not enough to get it running for you.

@amire80

This comment has been minimized.

Copy link
Author

commented Apr 19, 2014

Ah, awesome. I simply added "unpacked" in the test/index.html line that loads MathJax.js. I confirm that the menu is fixed. Thank you!

I hope to see it released and deployed on Wikipedia some time soon :)

@dpvc

This comment has been minimized.

Copy link
Member

commented Apr 19, 2014

Thanks for checking it for us. We hope to have a new bug-fix release soon.

dpvc pushed a commit to mathjax/MathJax-test that referenced this issue Apr 22, 2014

@dpvc

This comment has been minimized.

Copy link
Member

commented Apr 22, 2014

=> In Test Suite.

UI/math-menu/issue777-1.html
UI/math-menu/issue777-2.html
UI/math-menu/issue777-3.html

@dpvc dpvc added v2.4 and removed Merged labels Jun 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.