# Asciimathml meta issue for 2.x #857

Closed
opened this issue Jul 8, 2014 · 25 comments

Projects
None yet
3 participants
Member

### pkra commented Jul 8, 2014

 This issue is for keeping track of asciimathml changes which should be pulled back into MathJax for the next release. asciimath/asciimathml#14 -- switching phi and varphi, i.e., changing the defaults we set in #353 asciimath/asciimathml#19 -- leading space in quotes problem #883 #851 power of f and g #431 underscore #741

### drlippman commented Jul 8, 2014

 Would it be helpful for me to keep a copy of the mathjax asciimath input jax in the /mathjax/asciimathml repo, and keep it updated as we make changes to asciimathml? Or make pull requests to update the version in this repo? Or do you just want to manually merge every once and while?
Member Author

### pkra commented Jul 9, 2014

 Yes, all of the above sound good to keep asciimath development focused in one place. I guess if the asciimathml repo will contain a few variants, we might want to look into build tools like grunt, gulp etc to generate them.

Member Author

### pkra commented Aug 20, 2014

 @drlippman we're getting close to the next release. How much is pending on the asciimath side?

### drlippman commented Aug 20, 2014

 Nothing now :) I just merged in the pending changes into the asciimath repo. I also just updated the copy of the AsciiMath input jax in the asciimath repo to match the latest version of asciimathml.js and took it for a test drive. Everything seems to work fine. It would be great to get these updates in the next MathJax release.

### dpvc pushed a commit to dpvc/MathJax that referenced this issue Aug 21, 2014

 Update AsciiMath to current version from asciimath/mathjax. Issue mat… 
…hjax#857.
 7c83778 

Member

### dpvc commented Aug 21, 2014

 Thanks for your work on this, David. I have incorporated your changes (with some slight modifications to the MathJax portions and comments). Testing looks good.
Member Author

### pkra commented Aug 22, 2014

 Do we need to update the copyright notice in the code? It only lists Peter Jipsen right now.
Member

### dpvc commented Aug 22, 2014

 @drlippman, do you want to be added to the copyright notice? Should anyone else be listed as well?

### drlippman commented Aug 22, 2014

 I'm not particularly concerned about it but might be nice eventually, and might be nice to add a blanket acknowledgement of contributions. On a related note, is it OK that the top of the file mentions the Apache license, but later down it refers to LGPL?
Member Author

### pkra commented Aug 22, 2014

 I think that's mostly ok but we could follow the guidelines for a relates situation (GPL + MIT, http://www.softwarefreedom.org/resources/2007/gpl-non-gpl-collaboration.html) and keep both headers at the top.
Member

### dpvc commented Aug 22, 2014

 Hmmm. The link that you provide is to a description of how to include more-permissive licenses into GPL projects; our situation is that we have included a GPL document into a more-permissive Apache one. That usually isn't allowed under GPL, which is why we got special permission from Peter Jipsen to release it under the Apache2. So the GPL license that is part of the original file is not really in play, here. We do note the special dispensation at the top, but my understanding is that the entire file is Apache2.
Member Author

### pkra commented Aug 23, 2014

 Sorry for not posting more thoughts. Yes, this is about a different licensing situation. Still, the consequence seems to be similar. However, our current asciimathml copy states A portion of this file is taken from ASCIIMathML.js Version 2.2 Mar 3, 2014, (c) Peter Jipsen http://www.chapman.edu/~jipsen and is used by permission of Peter Jipsen, who has agreed to allow us to release it under the Apache2 license (see below). That portion is indicated via comments. So there's really no conflict at all. Could the asciimathml contributors agree to this in general? Otherwise, an update seems out of the question :(
Member

### dpvc commented Aug 24, 2014

 Otherwise, an update seems out of the question. So don't merge the changes for now?

### drlippman commented Aug 24, 2014

 I'm certainly fine with the Apache license, and I think I've been the only contributor to the code in question. For simplicity, I wonder if Peter would be OK with us just permanently relicensing asciimathml.js under Apache so this doesn't become an issue in the future. Or we probably should add a dual licensing contributor notice.
Member Author

### pkra commented Aug 25, 2014

 @drlippman could you sign http://www.mathjax.org/cla/ ? I'll write an email to you and Peter about the re-licensing question.
Member Author

### pkra commented Aug 25, 2014

 @dpvc So don't merge the changes for now? Yes, for now.

### drlippman commented Aug 25, 2014

 Done, thanks.
Member Author

### pkra commented Aug 25, 2014

 Thanks, David!
Member

### dpvc commented Sep 1, 2014

 @pkra, will you let me know when it is OK to go ahead with the merge for this?
Member Author

### pkra commented Sep 2, 2014

 @dpvc as soon as the the re-licensing of ASCIIMathML.js is complete. we can merge this. We also need to update our comments in the input jax. Not sure if we want to do this on the asciimathml repo or in our repo.
Member

### dpvc commented Sep 2, 2014

 I think we should consider our copy of the jax.js file to be the master copy, and the asciimath repo as the shadow in this case. So we should change the comments in our copy and they can merge that into theirs.
Member

### dpvc commented Sep 2, 2014

 Let me know when the re-licensing is done.
Member Author

### pkra commented Sep 2, 2014

 I think we should consider our copy of the jax.js file to be the master copy, I agree. Let me know when the re-licensing is done. That's asciimath/asciimathml#25
Member Author

### pkra commented Sep 13, 2014

 asciimath/asciimathml#25 has been merged.

Member

### dpvc commented Dec 6, 2014

 I still need to move the current copy of asciimath into our jax.js and merge that, so I'm moving this back to the v2.5 milestone.

### dpvc pushed a commit to dpvc/MathJax that referenced this issue Dec 31, 2014

 Merge branch 'issue857' into develop. Issue mathjax#857. 
 fa9fd91 
Member

### dpvc commented Dec 31, 2014

 New AsciiMath version has been merged.