Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathML pre-processor: mml preview not working #863

Closed
pkra opened this issue Jul 10, 2014 · 5 comments

Comments

Projects
None yet
2 participants
@pkra
Copy link
Member

commented Jul 10, 2014

It seems to me that the pre-processor's option for leaving the MathML as preview is not working.

To test, here are a lot of equations and a manually set preview option http://codepen.io/pkra/pen/FxDir

@pkra

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2014

Looks like it's just math.cloneNode(false) at https://github.com/mathjax/MathJax/blob/master/unpacked/extensions/mml2jax.js#L209 (which should be true, I think).

@pkra pkra added Accepted and removed In Development labels Jul 10, 2014

dpvc pushed a commit that referenced this issue Jul 18, 2014

@dpvc

This comment has been minimized.

Copy link
Member

commented Jul 18, 2014

==> Merged.

@dpvc dpvc added the Merged label Jul 18, 2014

@pkra

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2014

Glad it was that easy. Do we need a test for this?

@dpvc

This comment has been minimized.

Copy link
Member

commented Jul 21, 2014

Probably. It should not be too hard to make one. (It should just run the preprocessors and not the typesetting, and compare the results to a static page that is set up as the preview by hand.

@dpvc dpvc added this to the Next Release milestone Aug 17, 2014

@dpvc dpvc closed this Aug 17, 2014

dpvc pushed a commit to mathjax/MathJax-test that referenced this issue Jan 21, 2015

@dpvc dpvc added Test Available and removed Test Needed labels Jan 21, 2015

@dpvc

This comment has been minimized.

Copy link
Member

commented Jan 21, 2015

==> In Testsuite

Configuration/mml2jax/preview-4.html

@dpvc dpvc added Fixed v2.5 and removed Merged labels Jan 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.