Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow negative dimensions in \Rule and add \rule macro. #1666 #1673

Merged
merged 2 commits into from Jul 7, 2017

Conversation

Projects
None yet
2 participants
@dpvc
Copy link
Member

commented Dec 2, 2016

Make \Rule use <mspace> so that negative dimensions are handled.
Add \rule macro from LaTeX.

Resolves issue #1666.

@zorkow
Copy link
Member

left a comment

O/w lgtm.

mml = MML.mpadded(MML.mrow()).With(def);
} else {
mml = MML.mspace().With(def);
if (style !== 'blank') def.mathbackground = (this.stack.env.color || "black");

This comment has been minimized.

Copy link
@zorkow

zorkow Feb 9, 2017

Member

Can I get some braces for the if body, please.

This comment has been minimized.

Copy link
@dpvc

dpvc Feb 15, 2017

Author Member

I hate that for one-line bodies, but have done it for you.

@dpvc dpvc modified the milestone: MathJax v2.7.2 Jul 7, 2017

@dpvc

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2017

@zorkow, can you close the review so I can merge this? I added the braces you asked for. Thanks.

@zorkow

zorkow approved these changes Jul 7, 2017

@zorkow

This comment has been minimized.

Copy link
Member

commented Jul 7, 2017

lgtm.

@dpvc dpvc merged commit 6b38a81 into mathjax:develop Jul 7, 2017

@dpvc dpvc deleted the dpvc:issue1666 branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.