Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create composer.json #870

Merged
merged 1 commit into from Aug 5, 2014

Conversation

Projects
None yet
2 participants
@nineff
Copy link
Contributor

commented Jul 16, 2014

@pkra

This comment has been minimized.

Copy link
Member

commented Aug 5, 2014

Sorry I forgot about this (again :( )

I'm not sure what the author line should be used for. I'm thinking it could either be "MathJax Consortium" (as owner of MathJax) or additionally include all (code) contributors -- I think; I really don't know what composer wants there (the documentation seems to assume authorship and ownership coincide).

I can merge this now and we can fix it later. What do you think @Gefrierbrand ?

@nineff

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2014

I suggest to merge it now as it is. The author line is optional and just for information purposes, it does not affect composers behavior.
However putting "MathJax Consortium" in there seems way more logical than inserting each and every contributor, but this can be fixed later as you suggest.

pkra pushed a commit that referenced this pull request Aug 5, 2014

@pkra pkra merged commit 143d071 into mathjax:develop Aug 5, 2014

@pkra

This comment has been minimized.

Copy link
Member

commented Aug 5, 2014

Great! Thanks again for your contribution!

@pkra pkra referenced this pull request Aug 23, 2014

Closed

MathJax as composer package #844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.