-
Notifications
You must be signed in to change notification settings - Fork 46
Support for CapitalRaidSeasons and Context Manager #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it clearer how the class is modifying the URL string
…he `limit` parameter to change how pagination works
…ital raids). Some documentation and testing is still needed.
… It currently seems like the API contains the but and not the code. More testing is needed
G3 doluk iter
…filter is available, fix indexing in arrays if array length changes
Api request update
extend Client class to work with context manager
… out the context manager out of this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update has quite a bit of change without breaking backward compatibility.
For starters, support for the context manager was added #121 allowing the use of
Additionally, with the release of CapitalRaidSeasons we needed to improve the performance of fetching warlogs and capital raid logs. Previously, all records available from the API were fetched when in most cases, folks just needed the newest data. A
limitparameter has been added to bothget_warlogandget_raidlog.Additionally, support for
async for warloghas been added with the ability to fetch more data if needed.This PR includes:
#122
#121
#130
#131