Bedrock not always placed correctly #10

Closed
mathuin opened this Issue Apr 24, 2012 · 2 comments

Projects

None yet

1 participant

@mathuin
Owner
mathuin commented Apr 24, 2012

This can have some impressive effects if the bottom of the world is all sand, as seen here: Cascade Failure.

@mathuin
Owner
mathuin commented Apr 24, 2012

I strongly suspect this is due to the usage of trim and sealevel, causing the code that calculates the bottom to be off by one somewhere.

@mathuin
Owner
mathuin commented Apr 24, 2012

And I was right! When the value for y is smaller than the column generated by the terrain code, a negative amount of end stone is placed and bedrock is tacked on at the bottom.

I will fix this by moving the bedrock placement to outside the while core loop in terrain.py.

@mathuin mathuin added a commit that closed this issue Apr 26, 2012
@mathuin Fixes #10 by moving bedrock placement out of the while loop
The while loop allowed for bedrock to be overwritten so I
rewrote it putting bedrock in place before the loop begins
and adding a condition to keep it from being overwritten.
d6d2931
@mathuin mathuin closed this in d6d2931 Apr 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment