Vaibhav/milestone [DO NOT MERGE] #654

VAIBHAVJINDAL3012 · 2023-01-09T13:17:05Z

Description

Please provide a detailed description of what was done in this PR
This PR includes the changes which involves using the endBlock hash instead of rootHash in the milestone.

Changes

Bugfix (non-breaking change that solves an issue)
Hotfix (change that solves an urgent issue, and requires immediate attention)
New feature (non-breaking change that adds functionality)
Breaking change (change that is not backwards-compatible and/or changes current functionality)
Changes only for a subset of nodes

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Nodes audience

In case this PR includes changes that must be applied only to a subset of nodes, please specify how you handled it (e.g. by adding a flag with a default value...)

Checklist

I have added at least 2 reviewer or the whole pos-v1 team
I have added sufficient documentation in code
I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

This PR requires changes to heimdall
- In case link the PR here:
This PR requires changes to matic-cli
- In case link the PR here:

Testing

I have added unit tests
I have added tests to CI
I have tested this code manually on local environment
I have tested this code manually on remote devnet using express-cli
I have tested this code manually on mumbai
I have created new e2e tests into express-cli

Manual tests

Please complete this section with the steps you performed if you ran manual tests for this functionality, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

…into vaibhav/POS-609

…ibhav/POS-609 Pull from the develop branch

…lestoneNoReorg Pull from develop

codecov · 2023-03-24T07:54:15Z

Codecov Report

Patch coverage: 46.75% and project coverage change: -0.19 ⚠️

Comparison is base (808259b) 56.60% compared to head (b7e896d) 56.41%.

❗ Current head b7e896d differs from pull request most recent head e3582ca. Consider uploading reports for the commit e3582ca to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #654      +/-   ##
===========================================
- Coverage    56.60%   56.41%   -0.19%     
===========================================
  Files          610      615       +5     
  Lines        71266    72099     +833     
===========================================
+ Hits         40339    40674     +335     
- Misses       27466    27938     +472     
- Partials      3461     3487      +26

Impacted Files	Coverage Δ
accounts/abi/bind/backends/bor_simulated.go	`7.69% <0.00%> (-0.65%)`	⬇️
consensus/bor/api.go	`0.00% <0.00%> (ø)`
consensus/bor/bor.go	`7.50% <0.00%> (-0.03%)`	⬇️
consensus/bor/heimdall/metrics.go	`9.09% <ø> (ø)`
consensus/bor/valset/validator_set.go	`49.25% <0.00%> (-0.38%)`	⬇️
core/blockchain_reader.go	`42.06% <0.00%> (-1.38%)`	⬇️
core/forkchoice.go	`75.00% <ø> (ø)`
core/rawdb/bor_receipt.go	`1.23% <ø> (ø)`
core/rawdb/checkpoint.go	`0.00% <0.00%> (ø)`
core/rawdb/milestone.go	`0.00% <0.00%> (ø)`
... and 41 more

... and 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

… into vaibhav/Milestone Pull merge

github-actions · 2023-05-02T00:16:05Z