Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apostrophes, "in retrospect" #9

Merged
merged 1 commit into from Feb 16, 2020
Merged

apostrophes, "in retrospect" #9

merged 1 commit into from Feb 16, 2020

Conversation

@skierpage
Copy link
Contributor

skierpage commented Feb 16, 2020

it's designed principles
it's validity is enforced.

These aren't a contraction of "it is" or "it has", so no apostrophe.

The phrase is "obvious in retrospect", I also tweaked it to be, arguably, more idiomatic.

> it's designed principles
> it's validity is enforced.

These aren't a contraction of "it is" or "it has", so no apostrophe. It's hella confusing because one does write "I like Rust's style" with an apostrophe for the possessive form, but "its" is already the possessive pronoun. The way I remember it is: you don't write "I like hi's principles," and "its principles" and even "the idea was hers" work the same.

The phrase is "obvious in retrospect", I also tweaked it to be, arguably, more idiomatic.

Your enthusiasm, even love, for the Rust language comes across clearly and that's what really matters 😍
@matklad

This comment has been minimized.

Copy link
Owner

matklad commented Feb 16, 2020

bors r+

Thanks!

bors bot added a commit that referenced this pull request Feb 16, 2020
Merge #9
9: apostrophes, "in retrospect" r=matklad a=skierpage

> it's designed principles
> it's validity is enforced.

These aren't a contraction of "it is" or "it has", so no apostrophe.

The phrase is "obvious in retrospect", I also tweaked it to be, arguably, more idiomatic.

Co-authored-by: skierpage <info@skierpage.com>
@bors

This comment has been minimized.

Copy link
Contributor

bors bot commented Feb 16, 2020

@bors bors bot merged commit 4ba4e81 into matklad:src Feb 16, 2020
2 checks passed
2 checks passed
bors Build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.