New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config editors can crash if locale 'en_GB' misses #469

Closed
amak79 opened this Issue Sep 4, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@amak79

amak79 commented Sep 4, 2017

When starting gimx-fpsconfig I get the following message:

18:20:48: Cannot set locale to language "English".
18:20:48: locale 'en_GB' cannot be set.
18:20:48: Cannot set locale to language "English".
18:20:48: locale 'en_GB' cannot be set.
18:20:48: Cannot set locale to language "English".
18:20:48: locale 'en_GB' cannot be set.
18:20:48: Cannot set locale to language "English".
18:20:48: locale 'en_GB' cannot be set.
18:20:48: Cannot set locale to language "English".
18:20:48: locale 'en_GB' cannot be set.
18:20:48: Cannot set locale to language "English".
18:20:48: locale 'en_GB' cannot be set.
18:20:48: Cannot set locale to language "English".
18:20:48: locale 'en_GB' cannot be set.
18:20:48: Cannot set locale to language "English".
18:20:48: locale 'en_GB' cannot be set.

My current available locales are:

$ locale -a
C
en_AU
en_AU.iso88591
en_AU.utf8
POSIX

Adding the en_GB locale makes the message go away. Is there a reason why gimx-fpsconfig needs the en_GB locale? I don't have this issue with gimx-config or gimx-launcher.

@matlo

This comment has been minimized.

Show comment
Hide comment
@matlo

matlo Sep 4, 2017

Owner

The configs use '.' as a decimal separator. The apps temporarily change the locale to en_GB in code sections that handle numbers with a decimal separator, to ensure numbers can only have '.' as a decimal separator. It is a mistake as this locale may not be available. This definitely needs to be fixed.

Owner

matlo commented Sep 4, 2017

The configs use '.' as a decimal separator. The apps temporarily change the locale to en_GB in code sections that handle numbers with a decimal separator, to ensure numbers can only have '.' as a decimal separator. It is a mistake as this locale may not be available. This definitely needs to be fixed.

@matlo

This comment has been minimized.

Show comment
Hide comment
@matlo

matlo Sep 8, 2017

Owner

I just tried GIMX 6.8 without the en_GB locale on my system. It makes gimx-config crash.

Owner

matlo commented Sep 8, 2017

I just tried GIMX 6.8 without the en_GB locale on my system. It makes gimx-config crash.

@matlo matlo added bug GIMX 6.9 labels Sep 8, 2017

@matlo matlo changed the title from gimx-fpsconfig: locale 'en_GB' cannot be set to config editors can crash if locale 'en_GB' misses Sep 8, 2017

@matlo matlo closed this Sep 8, 2017

@matlo matlo reopened this Sep 8, 2017

@matlo matlo closed this Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment