Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our own, faster arrayCache, compat for Piwik 3 #13

Merged
merged 2 commits into from Sep 14, 2016

Conversation

Projects
None yet
2 participants
@tsteur
Copy link
Member

tsteur commented Sep 13, 2016

In Piwik 3.0 we require PHP 5.5.9 which causes it to use doctrine/cache@1.6.0 . There they added some features to array cache which we do not need like lifetime support and a hit counter etc. I therefore moved the code of the old doctrine array cache implementation into our own arrayCache and no longer extend the doctrine array cache. We are calling the array cache thousands of times in one request and therefore this matters there re performance and memory.

As we are now requiring PHP 5.5.9 we should afterwards release a new major version for this component: 1.0.0

refs matomo-org/matomo#10380

@tsteur tsteur merged commit 4cae403 into master Sep 14, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tsteur tsteur deleted the piwik3compat branch Sep 14, 2016

@mattab

This comment has been minimized.

Copy link
Member

mattab commented Sep 26, 2016

Very good to have spotted this. Did you manually check for doctrine cache changes to detect this problem or did you detect it while profiling the code?

@tsteur

This comment has been minimized.

Copy link
Member Author

tsteur commented Sep 26, 2016

I noticed it manually a few weeks ago when I was debugging a seg fault.

@mattab mattab added this to the 3.0.0 milestone Oct 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.