Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong device detection #3971

Closed
anonymous-piwik-user opened this issue Jun 2, 2013 · 4 comments
Closed

Wrong device detection #3971

anonymous-piwik-user opened this issue Jun 2, 2013 · 4 comments
Labels
Milestone

Comments

@anonymous-piwik-user
Copy link

@anonymous-piwik-user anonymous-piwik-user commented Jun 2, 2013

piwik detects my N9 with Meego/Harmattan using the default browser as 'Symbian' under 'Operating System families' and shows 'Nokia Browser' under browser.

Meego is not Symbian, this should appear under Meego or Other.

This occurs with Piwik 1.12 with the new Devices Plugin.
I am guessing the code responsible is plugins/DevicesDetection/UserAgentParserEnhanced/UserAgentParserEnhanced.php Line 154 and 205:227 when looking at commit 6804733ddcb9fcf72b2df3f796a0d5b228bb0ab2

@mattab
Copy link
Member

@mattab mattab commented Jun 3, 2013

Thanks for the report. we keep track of improvements to DevicesDetection in #3962 - please add further feedback there (already added yours)

@mattab
Copy link
Member

@mattab mattab commented Oct 8, 2013

Thanks for report. Could you post user agent that was detected wrongly?

We now have hundreds of unit tests and so would be able to make this fix if you provide a bit more info.

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Jan 20, 2014

In 6ff015e113ce56061387428e50429192ba8c5b4d: refs #3971 - detect Meego as 'Other Mobile' instead of 'Symbian'

@sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 10, 2014

We now have some tests covering Nokia N9 with Meego. See https://github.com/piwik/piwik/blob/master/tests/PHPUnit/Fixtures/userAgentParserEnhancedFixtures.yml#L15570
I'll close this ticket for now. If there is still something wrong, please reopen the ticket.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants