Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that UserAgentParserEnhanced is at least as precise as UserAgentParser #4205

Closed
mattab opened this issue Oct 8, 2013 · 2 comments
Closed

Comments

@mattab
Copy link
Member

@mattab mattab commented Oct 8, 2013

Tests were added in matomo-org/matomo#115
this will be super useful when we change the YML files.

A lot of work was done in improving the detection of devices and brands.

This ticket is about adding a test that will compare the output of the old UserAgentParser, for each of the thousands of user agent, and compare the detection with the new userAgentEnhanced.

When the results are different: is UserAgentParserEnhanced right? or is UserAgentParser right? Maybe we can improve UserAgentParserEnhanced thanks to this process.

@mattab
Copy link
Member Author

@mattab mattab commented Oct 8, 2013

In a684fec0042067ad800491dfd130b25bfa354b8b: Refs #4205 Slight improvements to test
fixes #3974, added test for "Mozilla/5.0 (Windows NT 6.2; WOW64; rv:20.0) Gecko/20100101 Firefox/20.0 SeaMonkey/2.17.1"

@mattab mattab added this to the Version 2.2 milestone Jul 8, 2014
@sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 8, 2014

I don't really think that is still required. DeviceDetector should detect much more already

@sgiehl sgiehl closed this Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants