Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client hints future #6584

Closed
JureMalovrh opened this issue Jan 18, 2021 · 5 comments
Closed

Client hints future #6584

JureMalovrh opened this issue Jan 18, 2021 · 5 comments

Comments

@JureMalovrh
Copy link

Given that the Client hints (spec) are planned for release in 2021, I am wondering are there any movement/discussions in this library regarding the future? Will this library try to support client hints parsing?

@sgiehl
Copy link
Member

sgiehl commented Jan 18, 2021

We have not yet discussed that with the team, but personally I wouldn't include that into this library. It's meant for useragent parsing.
But as Matomo at some point will need some kind of parsing of those client hints, we might need to consider building a new library for it maybe. But as long as it's not known how those client hint values will actually look like in all browsers, it's hard to say anything in detail.

@Findus23
Copy link
Member

Hi @JureMalovrh,

See here on more details on supporting Client hints in Matomo (which I guess will also involve a library that can then be used outside of Matomo): matomo-org/matomo#16125
But it seems to my like very little has changed on this topic in the last year

@sanchezzzhak
Copy link
Collaborator

Most likely, the current version can work in detecting the model and brand, but you will have to pass the data from JS yourself.
I hope the client-hints never show up.

@JureMalovrh
Copy link
Author

JureMalovrh commented Jan 18, 2021

Thanks for the answers and a link to a given discussion in your main project.

I agree with @sgiehl that this should be a separate library, but at the same time, similar parsing capabilities will probably be needed. I opened this question just to see what is the current stance of Matomo organization and to maybe "warm" people that this is coming, as I think currently a lot of people are not even aware that this is coming.

And yeah I also hope this will never show up, but the odds are not in our favor :).

@sgiehl
Copy link
Member

sgiehl commented Jul 19, 2021

Closing. As we won't support client hints here (as discussed)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants