New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed detect Asus zen 2 & go; + add zen 3 model + new brands #5593

Merged
merged 15 commits into from Mar 2, 2017

Conversation

Projects
None yet
3 participants
@sanchezzzhak
Contributor

sanchezzzhak commented Feb 27, 2017

fix detect Asus zen 2 & go; and add zen 3 model
new brand Supra
new brand MIXC
new brand Homtom
add model Samsung SM1S

sanchezzzhak added some commits Feb 22, 2017

Homtom detected models HT3 HT17 HT20 etc;
 Samsung CALME SM1S
 MIXC add models M35 M20 G7106 G7108
Asus ZenFone 2
(Linux; Android 5.0.2; ASUS_Z00LD Build/LRX22G)
Asus ZenFone 4
(Linux; U; Android 4.4.2; ru-; ASUS_T001 Build/KOT49H)
ZenFone Go (ASUS_X009DD/ ASUS_X009D/ ASUS_X009DA/. ASUS_X009DB)
 (Linux; Android 6.0.1; ASUS_X009DD Build/MMB29M)
ZenFone 3 Pegasus
 (MIDP-2.0; U; Adr 6.0; ru; ASUS_X008)
ZenFone Go Life
(Linux; Android 5.1.1; ASUS_X013D Build/LMY47V)
add detect NOUS models
 NS3, NS5, NS6, NS5003, NS5004, NS5006 NS5511
@coveralls

This comment has been minimized.

coveralls commented Feb 27, 2017

Coverage Status

Coverage remained the same at 98.584% when pulling afcd0ae on sanchezzzhak:pr-device1 into a84aedd on piwik:master.

@@ -223,6 +224,7 @@
'ME' => 'Metz',
'MX' => 'MEU',
'MI' => 'MicroMax',
'MIX' => 'MIXC',

This comment has been minimized.

@sgiehl

sgiehl Feb 27, 2017

Member

Please use only 2 characters as shortcode. If useful shortcodes are already taken use something like 'M1', 'M2'
(Piwik isn't able to handle longer short codes)

- regex: '(?:ASUS_)?Z00UD'
model: 'ZenFone Selfie'
- regex: '(?:ASUS_)?(Z017DA|ZE520KL)

This comment has been minimized.

@sgiehl

sgiehl Feb 27, 2017

Member

this line lacks a ' in the end and breaks some detections

@coveralls

This comment has been minimized.

coveralls commented Feb 28, 2017

Coverage Status

Coverage remained the same at 98.584% when pulling 3e80329 on sanchezzzhak:pr-device1 into f5b6ffc on piwik:master.

@sgiehl sgiehl changed the base branch from master to pr5593 Mar 2, 2017

@sgiehl

This comment has been minimized.

Member

sgiehl commented Mar 2, 2017

Thanks for the Pull Request. I'll merge this one in a new branch and fix the tests before merging into master.

@sgiehl sgiehl merged commit ab74015 into matomo-org:pr5593 Mar 2, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@mattab mattab changed the title from Pr device1 to fixed detect Asus zen 2 & go; + add zen 3 model + new brands Apr 3, 2017

@sanchezzzhak sanchezzzhak deleted the sanchezzzhak:pr-device1 branch Jun 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment