New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new brand SENSEIT and detect many models #5594

Merged
merged 9 commits into from Mar 9, 2017

Conversation

Projects
None yet
3 participants
@sanchezzzhak
Contributor

sanchezzzhak commented Mar 2, 2017

new brand SENSEIT detect models R390, R450, L301, A200, A109, E510, E500, E400

sanchezzzhak added some commits Feb 22, 2017

Merge branch 'master' of https://github.com/piwik/device-detector
Conflicts:
	Tests/fixtures/smartphone-4.yml
	regexes/device/mobiles.yml
@coveralls

This comment has been minimized.

coveralls commented Mar 2, 2017

Coverage Status

Coverage remained the same at 98.584% when pulling 005906e on sanchezzzhak:pr-device2 into d5ce669 on piwik:master.

@sanchezzzhak

This comment has been minimized.

Contributor

sanchezzzhak commented Mar 9, 2017

When it will be possible, can you please merge the request?

@coveralls

This comment has been minimized.

coveralls commented Mar 9, 2017

Coverage Status

Coverage remained the same at 98.584% when pulling 1abc8ec on sanchezzzhak:pr-device2 into d5ce669 on piwik:master.

fix Xperia C5 Ultra brand Sony;
add models Sony Xperia M5 -  E5603, E5606, E5653
add model Sony Xperia M5 Dual - E5633, E5643, E5663
@@ -1540,6 +1539,9 @@ Sony:
model: 'Xperia X'
- regex: '(?:Sony(?:Ericsson)?)?F5321'
model: 'Xperia X Compact'
- regex: 'E5506'

This comment has been minimized.

@sgiehl

sgiehl Mar 9, 2017

Member

Could you please change that to the previous regex: '(?:Sony(?:Ericsson)?)?E5506'

This comment has been minimized.

@sanchezzzhak

sanchezzzhak Mar 9, 2017

Contributor

done

@@ -1540,6 +1539,9 @@ Sony:
model: 'Xperia X'
- regex: '(?:Sony(?:Ericsson)?)?F5321'
model: 'Xperia X Compact'
- regex: 'E5506'
model: 'Xperia C5 Ultra'
brand: 'Sony'

This comment has been minimized.

@sgiehl

sgiehl Mar 9, 2017

Member

no need to define the brand here, as Sony is the default. You can remove this line

This comment has been minimized.

@sanchezzzhak

sanchezzzhak Mar 9, 2017

Contributor

done

regex: 'SENSEIT[ _]?([^;/)]+) Build'
device: 'smartphone'
models:
- regex: '(R390|R450|E[54][10]0|A109|A200|L301)'

This comment has been minimized.

@sgiehl

sgiehl Mar 9, 2017

Member

Why are you defining a sub regex here? The global regex should already match everything in this case. You could directly use:

# Senseit
Senseit:
   regex: 'SENSEIT[ _]?([^;/)]+) Build'
   device: 'smartphone'
   model: '$1'

It can be changed as soon as some extra detections needs to be added

This comment has been minimized.

@sanchezzzhak

sanchezzzhak Mar 9, 2017

Contributor

I did not know that it was possible, i will correct regex

@coveralls

This comment has been minimized.

coveralls commented Mar 9, 2017

Coverage Status

Coverage remained the same at 98.584% when pulling 6139c45 on sanchezzzhak:pr-device2 into d5ce669 on piwik:master.

@sgiehl

This comment has been minimized.

Member

sgiehl commented Mar 9, 2017

Seems correct now. Will merge as soon as the tests passed...

@sgiehl

sgiehl approved these changes Mar 9, 2017

@coveralls

This comment has been minimized.

coveralls commented Mar 9, 2017

Coverage Status

Coverage remained the same at 98.584% when pulling f2bd461 on sanchezzzhak:pr-device2 into d5ce669 on piwik:master.

@sgiehl sgiehl merged commit 5c6b042 into matomo-org:master Mar 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mattab mattab changed the title from Pr device2 to Add new brand SENSEIT and detect many models Apr 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment