New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new brand SENSEIT and detect many models #5594
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
235f6bf
new brand Homtom
sanchezzzhak e938e9a
Homtom detected models HT3 HT17 HT20 etc
sanchezzzhak 9ceec3e
Merge branch 'master' of https://github.com/piwik/device-detector
sanchezzzhak adc3285
Merge branch 'master' of https://github.com/piwik/device-detector
sanchezzzhak 005906e
adds models SENSEIT R390, R450, L301, A200, A109, E510, E500, E400
sanchezzzhak 1abc8ec
add detect model `Xperia C5 Ultra` user-agent ( Linux; Android 5.0; …
sanchezzzhak 6139c45
fix Xperia C5 Ultra brand Sony;
sanchezzzhak 24a5397
fix Senseit regex regular
sanchezzzhak f2bd461
fix Xperia C5 Ultra regex regular
sanchezzzhak File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1277,7 +1277,7 @@ Senseit: | |
|
||
# Sony & Sony Ericsson (combined as they are mixed up) | ||
Sony: | ||
regex: 'Sony(?: ?Ericsson)?|SGP|Xperia|C1[569]0[45]|C2[01]0[45]|C2305|C530[236]|C550[23]|C6[56]0[236]|C6616|C68(?:0[26]|[34]3)|C69(?:0[236]|16|43)|D200[45]|D21(?:0[45]|14)|D22(?:0[236]|12|43)|D230[2356]|D240[36]|D25(?:02|33)|D510[236]|D530[36]|D5322|D5503|D58[03]3|D65(?:0[23]|43)|D66[035]3|E210[45]|E2115|E5506|E2[03]03|E2306|E2312|E2353|E58[02]3|E5603|E6553|E66[358]3|E68[58]3|F3111|F331[13]|F3213|F5[13]21|F833[12]|(?:WT|LT|SO|ST|SK|MK)[0-9]+[a-z]*[0-9]*(?: Build|\))|X?L39H|XM50[ht]|W960|portalmmm/2\.0 K|S3[69]h|X10[ia]v?|E1[05][ai]v?|MT[0-9]{2}[a-z]? Build|SO-0(?:[345]D|[234]E|[12]C|[1235]F|[12]G)|R800[aix]|LiveWithWalkman' | ||
regex: 'Sony(?: ?Ericsson)?|SGP|Xperia|C1[569]0[45]|C2[01]0[45]|C2305|C530[236]|C550[23]|C6[56]0[236]|C6616|C68(?:0[26]|[34]3)|C69(?:0[236]|16|43)|D200[45]|D21(?:0[45]|14)|D22(?:0[236]|12|43)|D230[2356]|D240[36]|D25(?:02|33)|D510[236]|D530[36]|D5322|D5503|D58[03]3|D65(?:0[23]|43)|D66[035]3|E210[45]|E2115|E5506|E2[03]03|E2306|E2312|E2353|E58[02]3|E56[305][36]|E6553|E66[358]3|E68[58]3|F3111|F331[13]|F3213|F5[13]21|F833[12]|(?:WT|LT|SO|ST|SK|MK)[0-9]+[a-z]*[0-9]*(?: Build|\))|X?L39H|XM50[ht]|W960|portalmmm/2\.0 K|S3[69]h|X10[ia]v?|E1[05][ai]v?|MT[0-9]{2}[a-z]? Build|SO-0(?:[345]D|[234]E|[12]C|[1235]F|[12]G)|R800[aix]|LiveWithWalkman' | ||
device: 'smartphone' | ||
models: | ||
# SONY ERICSSON: explicit smartphone models | ||
|
@@ -1332,9 +1332,6 @@ Sony: | |
- regex: '(?:Sony(?:Ericsson)?)?WT19|LiveWithWalkman' | ||
model: 'Live with Walkman' | ||
brand: 'Sony Ericsson' | ||
- regex: '(?:Sony(?:Ericsson)?)?E5506' | ||
model: 'Xperia C5 Ultra' | ||
brand: 'Sony Ericsson' | ||
|
||
# SONY ERICSSON: explicit feature phone models | ||
- regex: '(?:Sony(?:Ericsson)?)?CK13i' | ||
|
@@ -1488,8 +1485,10 @@ Sony: | |
model: 'Xperia M4 Aqua' | ||
- regex: '(?:Sony(?:Ericsson)?)?E2312' | ||
model: 'Xperia M4 Aqua Dual' | ||
- regex: '(?:Sony(?:Ericsson)?)?E5603' | ||
- regex: '(?:Sony(?:Ericsson)?)?E56[05][36]' | ||
model: 'Xperia M5' | ||
- regex: '(?:Sony(?:Ericsson)?)?E5633' | ||
model: 'Xperia M5 Dual' | ||
- regex: '(?:Sony(?:Ericsson)?)?D2502' | ||
model: 'Xperia C3 Dual' | ||
- regex: '(?:Sony(?:Ericsson)?)?D2533' | ||
|
@@ -1540,6 +1539,9 @@ Sony: | |
model: 'Xperia X' | ||
- regex: '(?:Sony(?:Ericsson)?)?F5321' | ||
model: 'Xperia X Compact' | ||
- regex: 'E5506' | ||
model: 'Xperia C5 Ultra' | ||
brand: 'Sony' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no need to define the brand here, as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
|
||
# SONY: explicit tablet models | ||
- regex: 'SGP(?:311|312|321)[);/ ]|SO-03E' | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please change that to the previous regex:
'(?:Sony(?:Ericsson)?)?E5506'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done