New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bots for Czech Republic #5673

Merged
merged 4 commits into from Oct 17, 2017

Conversation

Projects
None yet
4 participants
@soukicz
Contributor

soukicz commented Oct 17, 2017

One major search engine and three "google shopping" alternatives.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 17, 2017

Coverage Status

Coverage remained the same at 98.584% when pulling 03fc77e on soukicz:master into c2c0c0c on piwik:master.

coveralls commented Oct 17, 2017

Coverage Status

Coverage remained the same at 98.584% when pulling 03fc77e on soukicz:master into c2c0c0c on piwik:master.

@matomo-org matomo-org deleted a comment from coveralls Oct 17, 2017

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Oct 17, 2017

Member

Thanks for the PR. Would you mind adding some tests for those bots in bots.yml or providing the user agents so we can add tests?

Member

sgiehl commented Oct 17, 2017

Thanks for the PR. Would you mind adding some tests for those bots in bots.yml or providing the user agents so we can add tests?

@Findus23

This comment has been minimized.

Show comment
Hide comment
@Findus23

Findus23 Oct 17, 2017

Member

Hi, It would be also nice if you could provide sqare icons for those websites, so I could add them to the piwik-icons.

Member

Findus23 commented Oct 17, 2017

Hi, It would be also nice if you could provide sqare icons for those websites, so I could add them to the piwik-icons.

@sgiehl

This comment has been minimized.

Show comment
Hide comment
@sgiehl

sgiehl Oct 17, 2017

Member

@Findus23 are you including images for bots as well?

Member

sgiehl commented Oct 17, 2017

@Findus23 are you including images for bots as well?

@Findus23

This comment has been minimized.

Show comment
Hide comment
@Findus23

Findus23 Oct 17, 2017

Member

Ah, thanks.
Forget what I wrote, I thought this was the searchengine-and-social-list
(@soukicz, you may want to add those websites there if they are missing)

Member

Findus23 commented Oct 17, 2017

Ah, thanks.
Forget what I wrote, I thought this was the searchengine-and-social-list
(@soukicz, you may want to add those websites there if they are missing)

@soukicz

This comment has been minimized.

Show comment
Hide comment
@soukicz

soukicz Oct 17, 2017

Contributor

Tests added

Contributor

soukicz commented Oct 17, 2017

Tests added

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 17, 2017

Coverage Status

Coverage remained the same at 98.584% when pulling f93e3e5 on soukicz:master into c2c0c0c on piwik:master.

coveralls commented Oct 17, 2017

Coverage Status

Coverage remained the same at 98.584% when pulling f93e3e5 on soukicz:master into c2c0c0c on piwik:master.

@sgiehl sgiehl merged commit 9d0a955 into matomo-org:master Oct 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

bpolaszek added a commit to bpolaszek/device-detector that referenced this pull request Oct 18, 2017

Add bots for Czech Republic (matomo-org#5673)
* add bots (Czech Republic)

* update bot category

* remove duplicated bot definition

* add test for Czech robots

sgiehl added a commit that referenced this pull request Oct 18, 2017

PSR-6 & PSR-16 compliant cache bridges (#5665)
* PSR-6 & PSR-16 compliant cache bridges

* Fix return values

* Added support for Edge/Android and Edge/iOS ... (#5667)

* added support for Edge/Android and Edge/iOS ...

* fixed tests

* Edge/Android and Edge/iOS to the same Edge-naming ...

* Adds detection for recent Apple devices (#5669)

* DAVDroid recognition (#5671)

* Update bots.yml (#5670)

* Update bots.yml

Improve detect seznan images mail proxy.

* Update bots.yml

Fix error

* adds test

* Rewritten Caching section in README

* Add bots for Czech Republic (#5673)

* add bots (Czech Republic)

* update bot category

* remove duplicated bot definition

* add test for Czech robots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment