New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect devices MTC, Primepad, Lemnov #5825

Merged
merged 11 commits into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@sanchezzzhak
Contributor

sanchezzzhak commented Oct 8, 2018

MTC devices
Primepad devices
Lemnov devices
Asus devices
Texet devices

@sanchezzzhak

This comment has been minimized.

Contributor

sanchezzzhak commented Oct 8, 2018

MTC - Russian mobile operator creates its """masterpieces""" =) on the basis of ZTE

sanchezzzhak added some commits Oct 8, 2018

@sgiehl

Thanks for the PR!
Left a few minor comments

Show resolved Hide resolved regexes/device/mobiles.yml Outdated
@@ -3882,6 +3926,8 @@ LG:
model: '$1'
- regex: '(VX[0-9]+)'
model: '$1'
- regex: '(Nexsus 5)'

This comment has been minimized.

@sgiehl

sgiehl Oct 8, 2018

Member

Isn't that the same as Google's Nexus 5 (which was produced by LG)

This comment has been minimized.

@sanchezzzhak

sanchezzzhak Oct 8, 2018

Contributor

I'm not really sure it's Google.
Nexsus 5 China DIY device
Nexus 5 Google+LG

This comment has been minimized.

@sgiehl

sgiehl Oct 8, 2018

Member

Ah so it's a copy of the Nexus 5?

This comment has been minimized.

@sanchezzzhak

sanchezzzhak Oct 8, 2018

Contributor

maybe

Show resolved Hide resolved regexes/device/mobiles.yml Outdated
Show resolved Hide resolved regexes/device/mobiles.yml Outdated

sanchezzzhak and others added some commits Oct 8, 2018

sanchezzzhak
sanchezzzhak
PR Fix MTC regexp conflict
Texet add detect devices

@sgiehl sgiehl merged commit 37ee043 into matomo-org:master Oct 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sanchezzzhak sanchezzzhak deleted the sanchezzzhak:device_part9 branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment