New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds detection for ComTrade Tesla devices #5850

Merged
merged 3 commits into from Oct 21, 2018

Conversation

Projects
None yet
2 participants
@liviuconcioiu
Contributor

liviuconcioiu commented Oct 20, 2018

refs #5808 - adds detection for ComTrade Tesla devices

Adds detection for ComTrade Tesla devices
refs #5808 - adds detection for ComTrade Tesla devices
@@ -127,6 +127,7 @@
'CU' => 'Cube',
'CY' => 'Coby Kyros',
'C6' => 'Comio',
'C7' => 'ComTrade Tesla',

This comment has been minimized.

@sgiehl

sgiehl Oct 20, 2018

Member

please use spaces instead of tabs here

liviuconcioiu added some commits Oct 20, 2018

Adds detection for ComTrade Tesla devices
refs #5808 - adds detection for ComTrade Tesla devices
Adds detection for ComTrade Tesla devices
refs #5808 - adds detection for ComTrade Tesla devices
@sgiehl

This comment has been minimized.

Member

sgiehl commented Oct 21, 2018

Any reason for naming the brand ComTrade Tesla? Doesn't the brand is called Tesla, even if it's currently owned by Comtrade.

@liviuconcioiu

This comment has been minimized.

Contributor

liviuconcioiu commented Oct 21, 2018

I tried to do that, but it conflicts with the Tesla car browser...

@sgiehl

This comment has been minimized.

Member

sgiehl commented Oct 21, 2018

Ah forget about that. You're right... So guess it's fine to name it that way.

@sgiehl sgiehl merged commit 6b36106 into matomo-org:master Oct 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@liviuconcioiu liviuconcioiu deleted the liviuconcioiu:tesla branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment