New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves detection of various Bmobile devices #5852

Merged
merged 10 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@liviuconcioiu
Contributor

liviuconcioiu commented Oct 21, 2018

Improves detection of various Bmobile devices

liviuconcioiu added some commits Oct 21, 2018

Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
- regex: 'AX-340'
model: 'AX340'
- regex: 'AX7OO'
model: 'AX700'

This comment has been minimized.

@sgiehl

sgiehl Oct 21, 2018

Member

Are there any devices of other brands starting with AX? Otherwise we maybe could simplify the whole detections by using AX-?([1-9][0-9]{2,3}) for all and in the overall match

@liviuconcioiu

This comment has been minimized.

Contributor

liviuconcioiu commented Oct 21, 2018

From what I've seen there is only one, Mozilla/5.0 (Linux; Android 4.4.2; AX4Nano Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/30.0.0.0 Mobile Safari/537.36, Allview AX4 Nano.

@sgiehl

This comment has been minimized.

Member

sgiehl commented Oct 21, 2018

ok. but that wouldn't match the regex I mentioned before

Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
@@ -1407,17 +1407,11 @@ Blaupunkt:
# Bmobile
Bmobile:
regex: 'Bmobile[_ ]|AX10(?:[1234567]0|[1345678]5|16|65E|70e|73\+|7[1234]|91)|AX(?:5[12347]0|512|5[123]5|524|6[01256789]0|[67]05|675|68[0135]|680\+|710|745|810|82[013]|92[012])|AX-340|AX7OO'
regex: 'Bmobile[_ ]|AX-?([1-9][0-9eEO+]{2,4})'

This comment has been minimized.

@sgiehl

sgiehl Oct 22, 2018

Member

I guess the eEO+ can only be at the end, right? So maybe we should use AX-?([1-9][0-9]{2,3}[eEO+])

This comment has been minimized.

@liviuconcioiu

liviuconcioiu Oct 23, 2018

Contributor

You forgot to add a ? sign. Also, they made a typo mistake on the user agent, instead of 700 they wrote 7OO, but on their website the model is 700. I think this is the final regex AX-?([1-9][0-9]{2,3}[eEO+]?|7OO)

liviuconcioiu added some commits Oct 23, 2018

Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices
Improves detection of various Bmobile devices

@sgiehl sgiehl merged commit 62099b1 into matomo-org:master Oct 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment