New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds detection for Top House devices #5861

Merged
merged 3 commits into from Oct 28, 2018

Conversation

Projects
None yet
2 participants
@liviuconcioiu
Contributor

liviuconcioiu commented Oct 24, 2018

refs #5782 - adds detection for Top House devices

Adds detection for Top House devices
refs #5782 - adds detection for Top House devices
regex: 'Coto[_ ]|X1013'
device: 'smartphone'
models:
- regex: '(Coto W418)'

This comment has been minimized.

@sgiehl

sgiehl Oct 25, 2018

Member

As there is no dynamic part we should simply use a "static" match

- regex: 'Coto W418'
  model: 'Coto W418'

same applies for X1013

liviuconcioiu added some commits Oct 28, 2018

Adds detection for Top House devices
refs #5782 - adds detection for Top House devices
@sgiehl

sgiehl approved these changes Oct 28, 2018

@sgiehl sgiehl merged commit b26aacd into matomo-org:master Oct 28, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@liviuconcioiu liviuconcioiu deleted the liviuconcioiu:tophouse branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment