Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect new brands: Artel, A1, Swisstone and Detect devices for existing brands: RCA Tables, ZTE, Digma, Wiko, Vivo, Google, Tone, CUBOT, OPPO, Aligator, Blu, Logicom, Huawei #6405

Merged
merged 19 commits into from Oct 30, 2020

Conversation

sanchezzzhak
Copy link
Collaborator

No description provided.

sanchezzzhak and others added 12 commits October 25, 2020 23:50
 Air, Komi 3, Tomchi, Premium, U3 4G, Z5, Star, Sentinel X, Sentinel X D5,
 Sentinel X 8G, Nova, Connect, Choice, Style
…) (5002D_RU, 5002D_EEA, 5002D, 5002A)

feat(device) detect brand Aligator model: S6500
feat(device) detect new brand ZTE models: A1 Alpha 20+, A1 Alpha
feat(device) detect brand Oppo model: Reno 3 5G (A001OP)
feat(device) detect brand Kiano model: Elegance 6 5.85"
feat(device) detect brand Wiko models: View 4 (W-V730-EEA), View 4 Lite (W-V730-EEA)
feat(device) detect brand Huawei model: MatePad 10.4" (BAH3-L09)
feat(device) detect brand POCO model: X3 NFC
feat(device) detect brand Alcatel model: 3T 10 (8088X)
feat(device) detect brand Blu model: View Mega (B110DL)
feat(device) detect brand Logicom model: L-Egant One R
feat(device) detect brand Huawei model: Y9 (2019) (JKM-AL00a)
feat(device) detect brand RCA tablet model: Galileo Pro 11.5" (RCT6513W87)
# Conflicts:
#	Tests/fixtures/smartphone-17.yml
#	Tests/fixtures/tablet-2.yml
@sanchezzzhak
Copy link
Collaborator Author

sanchezzzhak commented Oct 27, 2020

@sgiehl Which size in rows is easier to accep in PR?
1000 or 2500 lines?

@sgiehl
Copy link
Member

sgiehl commented Oct 27, 2020

the smaller it is the faster I am with reviewing it...

@sanchezzzhak sanchezzzhak changed the title Pr device 60 Detect new brands: Artel, A1, Swisstone and Detect devices for existing brands: RCA Tables, ZTE, Digma, Wiko, Vivo, Google, Tone, CUBOT, OPPO, Aligator, Blu, Logicom, Huawei Oct 27, 2020
@@ -14289,6 +14329,8 @@ Xiaomi:
model: 'Redmi 10X Pro'
- regex: 'Redmi K20 Pro(?:[);/ ]|$)'
model: 'Redmi K20 Pro'
- regex: 'Redmi K30 5G(?:[);/ ]|$)'
model: 'Redmi K30 5G'

- regex: 'MI PAD 4 PLUS(?:[);/ ]|$)'
model: 'Mi Pad 4 Plus'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we make the same format for MI * model names for the Xiaomi brand?
Mi Pad 4 Plus => MI Pad 4 Plus or MI Pad 4 Plus => Mi Pad 4 Plus

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Sounds good

feat(device) detect brand Xiaomi models: Black Shark 3 5G (SHARK KLE-H0), Black Shark 3 Pro 5G (SHARK MBU-H0)
feat(device) detect brand Transpeed model: H616
feat(device) detect brand Realme models: 7 Pro (RMX2170), X3 Super Zoom (RMX2085), X50 Pro 5G (RMX2075)
device: 'smartphone'
models:
- regex: '(?:5022[EDX]|5070D)(?:[);/ ]|$)'
- regex: '5022[EDX]|5070D'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes should actually be ok. But we need to keep in mind, that removing those checks means that it might create false positive matches for strings that start with the regexes but are longer. In this case for example 5070DF443

@sgiehl sgiehl merged commit 71160b2 into matomo-org:master Oct 30, 2020
@sanchezzzhak sanchezzzhak deleted the pr_device_60 branch November 13, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants