New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No filename/lineno on error 400 #72

Closed
cbay opened this Issue May 11, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@cbay
Collaborator

cbay commented May 11, 2015

I've recently upgraded Piwik, and now when piwik_import_logs gets an error 400 during the import, it doesn't give the filename/fileno. I'm pretty sure it was specified in previous versions.

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab May 13, 2015

Member

Do you maybe have an example of what filename/fileno you would like to see when there is a 400 error?

Member

mattab commented May 13, 2015

Do you maybe have an example of what filename/fileno you would like to see when there is a 400 error?

@cbay

This comment has been minimized.

Show comment
Hide comment
@cbay

cbay May 13, 2015

Collaborator

I think it's hard to pinpoint the exact filename/lineno that failed, but I think we should at least print the number of parsed lines in fatal_error if no filename/fileno was passed. This way you'd have a rough estimate of where it failed, which is better than no estimate at all.

Collaborator

cbay commented May 13, 2015

I think it's hard to pinpoint the exact filename/lineno that failed, but I think we should at least print the number of parsed lines in fatal_error if no filename/fileno was passed. This way you'd have a rough estimate of where it failed, which is better than no estimate at all.

@diosmosis diosmosis closed this in c6200a8 Aug 25, 2015

diosmosis added a commit to matomo-org/matomo that referenced this issue Aug 25, 2015

@diosmosis diosmosis added this to the Current sprint milestone Aug 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment