Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Piwik Mobile to display Custom Variables values when a Custom var name is clicked #2654

Closed
mattab opened this issue Sep 11, 2011 · 27 comments
Closed
Assignees

Comments

@mattab
Copy link
Member

@mattab mattab commented Sep 11, 2011

When clicking on a row (Custom var name) Piwik mobile would show a subtable with values (custom var values)
Requested in: http://forum.piwik.org/read.php?2,76375

Piwik Mobile requirements:

  • Is Piwik Mobile already able to display a subtable in the same screen?
  • Or would Piwik Mobile reload the screen to display only the Custom var values after clicking on a Custom var name?
    In this case, the "swipe / back" gesture would come back to the previous "Custom variable names" report.

Both solutions would be fine IMO... whatever is easiest/best could be done?

There are also "Piwik core" requirements to make this feature work:

  • Piwik Metadata API also returns which API to call when a row is clicked eg. CustomVariables.getCustomVariablesValuesFromNameId

  • Piwik metadata should support the API call CustomVariables.getCustomVariablesValuesFromNameId currently unsupported

    Then piwik mobile would call metadata API for this API method which would return the whole report for the row clicked, as a standard Piwik report

Any feedback please post a comment!

@tsteur
Copy link
Member

@tsteur tsteur commented Oct 25, 2011

I'd like to work on this feature. Also want to display a subtable for pages. For example clicking on '/support' opens '/support/contact', '/support/faq', ...

Therefore the api has to return which API to call when a row is clicked (as you mentioned) and maybe which parameter to pass.

@mattab
Copy link
Member Author

@mattab mattab commented Oct 25, 2011

see also #2742

@tsteur
Copy link
Member

@tsteur tsteur commented Jun 24, 2012

(In [6500]) refs #2654 refactored TableView and StatisticList. Also fixed some possible memory leaks

@tsteur
Copy link
Member

@tsteur tsteur commented Jun 24, 2012

(In [6501]) refs #2654 prevent cleanup from list of reports window on iPad

@mattab
Copy link
Member Author

@mattab mattab commented Jul 3, 2012

Moving to Piwik core so that we hopefully get going in the next 2 months on this :)

@mattab
Copy link
Member Author

@mattab mattab commented Aug 17, 2012

Thanks Benaka for your work on this and unblocking Thomas to continue improving Piwik Mobile, to display the very useful sub-table analytics data!

@tsteur
Copy link
Member

@tsteur tsteur commented Aug 28, 2012

(In [6880]) refs #2654 a first working version. still have to do lots of tests and detect possible memory leaks

@tsteur
Copy link
Member

@tsteur tsteur commented Aug 29, 2012

(In [6881]) refs #2654 make sure cleanup continues even if there are errors

@tsteur
Copy link
Member

@tsteur tsteur commented Aug 30, 2012

(In [6889]) refs #2654 make sure tableview eventlistener will be added only once

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 1, 2012

(In [6896]) refs #2654 make sure the label has always the same left position even if hasChild is true

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 1, 2012

(In [6898]) refs #2654 display subtables only if Piwik version is 1.8.4 or newer

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 2, 2012

(In [6903]) refs #2654 request piwik version max once a day

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 2, 2012

(In [6904]) refs #2654 do not overwrite an already existing version if something went wrong during request

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 2, 2012

(In [6906]) refs #2654 track piwik version as a page custom variable

@mattab
Copy link
Member Author

@mattab mattab commented Sep 3, 2012

Excellent !! Users will love this... such an important feature and will expose critical data in the mobile app. Kuddos Thomas and Benaka :)

Some questions;

  • do you leave the parent table visible and display the subtable - or do you only display the subtable in a new window?
  • Thomas would you mind posting some screenshots of the feature?

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 3, 2012

Sure! I'll add some screenshots. You'll notice that the screenshot of the subtable don't display a "websites selector". This is because the subtable report won't exist in another website. Therefore it makes no sense to be able to switch the website there. It would result in an error.

I don't leave the parent table visible but instead open a new window to display the subtable. Everything else would be really tricky / hard to implement with Titanium. In addition it has some advantages to do it this way. Users can view the graph, change date/metric, better readable, if a subtable had subtables it would be possible to open even those :) I think it's also more "mobile-like"

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 3, 2012

Attachment:
Screenshot_229.png

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 3, 2012

Attachment:
Screenshot_230.png

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 4, 2012

(In [6915]) refs #2654 make sure piwik server version will be updated if a user changes an account

@mattab
Copy link
Member Author

@mattab mattab commented Sep 5, 2012

Good, on the "Back" button when viewing the subtable, could you write the
name of the parent report ie. "Custom Variables" instead of "Back" on the
button?

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 5, 2012

I had wrote the name of the parent report ie "Custom Variables" instead of "Back" in a first version and then replaced it with "Back". There is often not enough space on a mobile device. Shall I do it though? It definitely makes sense on the iPad, not sure for iPhone. Maybe it is indeed better to have a shortened title instead of only "Back". I'll attach another screenshot.

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 5, 2012

Attachment:
Screenshot_232.png

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 5, 2012

(In [6919]) refs #2654 display name of parent report instead of only Back

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 5, 2012

I thought about it... I think it's definitely better to write the name of the parent report instead of "Back".

@mattab
Copy link
Member Author

@mattab mattab commented Sep 6, 2012

Definitely, however, can you please split 2 words on 2 lines as it would look much better and use less width!

@tsteur
Copy link
Member

@tsteur tsteur commented Sep 6, 2012

It's not possible to split text into multiple lines in header. Multiple lines are not supported by Titanium there and I'm pretty sure also not by iOS. It's also not possible to specify the width or height of the back button.

@mattab
Copy link
Member Author

@mattab mattab commented Sep 7, 2012

Ok thanks for confirming - it's nice as it is.

@mattab mattab added this to the Piwik Mobile Client milestone Jul 8, 2014
@tsteur tsteur added this to the Piwik Mobile 1 milestone Jul 25, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants