New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed domainFixup() causing PHP Notice #12

Merged
merged 1 commit into from Sep 9, 2015

Conversation

Projects
None yet
2 participants
@HomerBond005
Contributor

HomerBond005 commented Sep 9, 2015

Fixed a small notice in domainFixup(...) getting thrown when the cookie domain is empty/default:

PHP Notice: Uninitialized string offset: -1 in .../PiwikTracker.php on line 449

Solution: Before checking the char at length - 1, check if length is greater than 0

mattab pushed a commit that referenced this pull request Sep 9, 2015

Matthieu Aubry
Merge pull request #12 from HomerBond005/master
Fixed domainFixup() causing PHP Notice

@mattab mattab merged commit 9a70fe3 into matomo-org:master Sep 9, 2015

@mattab

This comment has been minimized.

Show comment
Hide comment
@mattab

mattab Sep 9, 2015

Member

Thanks for the PR!

Member

mattab commented Sep 9, 2015

Thanks for the PR!

mattab added a commit to matomo-org/matomo that referenced this pull request Sep 14, 2015

dhoko pushed a commit to dhoko/piwik that referenced this pull request Sep 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment