From 32528145387ce1043b0ad5b974dc8db82a95b462 Mon Sep 17 00:00:00 2001 From: Thomas Steur Date: Tue, 19 Aug 2014 15:07:40 +0200 Subject: [PATCH] refs #5414 this should fix the seg fault on PHP 5.3.6. I did install an Apache + PHP 5.3.6 and was able to reproduce --- core/Plugin/Settings.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/core/Plugin/Settings.php b/core/Plugin/Settings.php index abc03368be6..2a8a72673f6 100644 --- a/core/Plugin/Settings.php +++ b/core/Plugin/Settings.php @@ -125,11 +125,14 @@ public function getSettingsForCurrentUser() return $setting->isWritableByCurrentUser(); }); - uasort($settings, function ($setting1, $setting2) use ($settings) { + $settings2 = $settings; + + uasort($settings, function ($setting1, $setting2) use ($settings2) { + /** @var Setting $setting1 */ /** @var Setting $setting2 */ if ($setting1->getOrder() == $setting2->getOrder()) { // preserve order for settings having same order - foreach ($settings as $setting) { + foreach ($settings2 as $setting) { if ($setting1 === $setting) { return -1; }